Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/bundle-heishamon-081.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"ftw": patch
---

Bundle heishamon 0.8.1. FTW no longer resets a Panasonic Aquarea's heat
curve offset at every start and watchdog trip unless FTW itself set it, so an
offset set from Home Assistant now stays.
2 changes: 1 addition & 1 deletion drivers/BUNDLED_SOURCE.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"from the signed channel. Run scripts/sync-bundled-drivers.sh to update."
],
"repository": "srcfl/device-drivers",
"commit": "1e4b5de7c055885481a8ba4a56476bd1bc1b7bbb",
"commit": "940a9136e4e08410f9f2a759438f13559f80f09b",
"source_dir": "drivers/lua",
"drivers": [
"ambibox_v2x", "ctek", "ctek_hybrid", "ctek_v2", "deye", "easee_cloud",
Expand Down
18 changes: 18 additions & 0 deletions go/internal/drivers/heishamon_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,3 +88,21 @@ func TestHeishamonClampsOffsetAndDefaultModeResetsIt(t *testing.T) {
t.Errorf("default-mode publish = %+v, want safe offset 0", pubs[1])
}
}

// Core runs default mode at every start and on watchdog trips. Until FTW has
// written an offset, neither default mode nor cleanup may touch the pump: the
// owner may have set the offset from Home Assistant (srcfl/device-drivers#233).
func TestHeishamonLeavesAnOffsetFTWNeverWrote(t *testing.T) {
var mqtt *fakeMQTT
// Registered first, so it runs after the driver's own cleanup.
t.Cleanup(func() {
if pubs := mqtt.Published(); len(pubs) != 0 {
t.Errorf("published = %v, want nothing before FTW wrote an offset", pubs)
}
})
var d *LuaDriver
d, mqtt, _ = newTestHeishamonDriver(t)
if err := d.DefaultMode(); err != nil {
t.Fatalf("default mode: %v", err)
}
}
Loading