Repository navigation
fix(drivers): bundle heishamon 0.8.1, an offset set elsewhere stays - #2036
Merged
Merged
Conversation
srcfl/device-drivers#235 makes default mode and cleanup reset Z1_Heat_Request_Temp only after FTW wrote an offset. Core runs default mode at every start and on watchdog trips, so an offset set from Home Assistant went back to 0 each time (srcfl/device-drivers#233). The pin moves 1e4b5de7 to 940a9136; heishamon is the only driver that changes. The new test runs the driver through Core's own Lua host, whose mqtt_publish returns nothing on success. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
heishamon 0.8.0 published
safe_offset(default 0) toZ1_Heat_Request_Tempfrom bothdriver_default_mode()anddriver_cleanup(). Core runs default mode at every start and on watchdog trips, so an offset the owner set from Home Assistant went back to 0 each time, even on a site where FTW never commanded the pump (srcfl/device-drivers#233, reported by @Romaost).Change
1e4b5de7to940a9136, which is fix(heishamon): reset the offset only after FTW wrote one (0.8.1) device-drivers#235 (heishamon 0.8.1). heishamon is the only bundled driver that changes.TestHeishamonLeavesAnOffsetFTWNeverWroteruns the driver through Core's own Lua host, whosemqtt_publishreturns nothing on success. The device-drivers mock returnstrue, so this checks the path the harness cannot.Known limit
After a Core crash the driver no longer knows FTW wrote, so that offset stays on the pump. Today only the operator's offset control on the heating card sends
set_heat_curve_offset, so the value that stays is one the owner chose.Tests
TestHeishamonLeavesAnOffsetFTWNeverWrotefails on 0.8.0 (two publishes of0) and passes on 0.8.1. The existingTestHeishamonClampsOffsetAndDefaultModeResetsItstill passes: after a command, default mode still resets.scripts/sync-bundled-drivers.sh --checkpasses.make verify: vet, test and build clean.940a9136:validate,pagesandftw-drivers-releasegreen.Not yet checked on hardware. @Romaost has offered to test on WH-SXC09H3E8.
Draft #1792 also edits
drivers/BUNDLED_SOURCE.json. The pin has moved several times since it was opened, so its rebase does not change with this one.🤖 Generated with Claude Code