Repository navigation
Add Simplified Chinese translation (part 1) and fix Hugo build error - #55
Merged
Merged
Conversation
bailuocf
marked this pull request as ready for review
September 27, 2026 03:08
bailuocf
marked this pull request as draft
September 27, 2026 03:09
Contributor
Author
|
Re-run |
bailuocf
marked this pull request as ready for review
October 27, 2026 03:15
Contributor
Author
|
Hi @prokoudine, I have marked this PR as ready for review and resolved the previous issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @prokoudine,
I've completed the first part of the Simplified Chinese (
zh) translation, including the UI strings, homepage, and conventions page. I've also made a few fixes to ensure the site builds correctly with newer Hugo versions and that dependencies are up to date.Changes included:
i18n/zh.yaml,content/_index.zh.md, andcontent/conventions/index.zh.md.hugo.yaml):.Site.Authorwas removed in recent Hugo versions).labelinstead oflanguageNamefor the newzhblock, aslanguageNameis deprecated in Hugo v0.158.0+. I left the existingen,fr, anditblocks untouched to keep the diff clean.go.mod,go.sum): Ranhugo mod get -u github.com/imfing/hextrato update the theme fromv0.11.1tov0.12.3. This is required because the old theme version crashes with newer Hugo versions (v0.156.0+) due to the removal of.Site.Author.Testing:
Tested locally with
hugo server. Everything builds and renders correctly.Note on Language Ordering:
I noticed the Spanish translation PR (#38) is still open. I set
weight: 4for the Chinese (zh) block. If my PR is merged first, this won't affect the existingen,fr, oritlanguage order. When the Spanish PR is eventually merged, it can takeweight: 5seamlessly. The ordering will remain stable.Before I continue with the remaining tutorial pages, could you please review the file naming (
_index.zh.md,zh.yaml) and the config changes? Let me know if this looks good to you.Thanks!