Repository navigation
Accept a urdf per model in vrx_gz spawn configs - #895
Open
luisfelipewb wants to merge 1 commit into
Open
luisfelipewb wants to merge 1 commit into
luisfelipewb wants to merge 1 commit into
Conversation
Spawn config entries can now set urdf:, so a config file can spawn vehicles other than the WAM-V. set_urdf() also resolves package://<pkg>/<path> against the package's share directory, which the urdf launch argument gets as well. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Luis Felipe Wolf Batista <luis.batista@gatech.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
competition.launch.pyhas two ways to spawn:config_file:=sets the pose (and supports several vehicles) but ignores any URDF, whileurdf:=sets the URDF but uses the fixed default pose. So a custom vehicle can't be spawned at a chosen position.This PR lets each spawn config entry set
urdf, andset_urdf()resolvespackage://<pkg>/<path>against the package's share directory, so both the config key and the existingurdf:=argument accept it:Entries without
urdfbehave as before. Related: #894 (robot_state_publisheruses the model name, needed for vehicles not namedwamv).Testing
Ubuntu 24.04, ROS 2 Jazzy, Gazebo Harmonic:
urdf:=package://wamv_gazebo/urdf/wamv_gazebo.urdf.xacroresolves to the installed path and the WAM-V spawns as before.sydney_regattaand a custom world: