Skip to content

Feature/panoramax - #236

Merged
tnagorra merged 6 commits into
developfrom
feature/panoramax
Nov 3, 2026
Merged

Feature/panoramax#236
tnagorra merged 6 commits into
developfrom
feature/panoramax

Conversation

@ofr1tz

@ofr1tz ofr1tz commented Feb 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Depends on

Changes

This enables the MapSwipe backend to handle View Streets projects with different image providers (currently Mapillary and Panoramax).

  • Adds image provider to the View Streets project specifics
  • Adds logic to download and process Panoramax metadata
  • Maps Panoramax metadata attribute names on the respective Mapillary attribute names for filtering
  • Changes max length of task ID to accommodate Panoramax image IDs as task IDs

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@codecov

codecov Bot commented Feb 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.69281% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.97%. Comparing base (3d613bb) to head (e833a2f).

Files with missing lines Patch % Lines
project_types/street/api_calls.py 92.50% 1 Missing and 2 partials ⚠️
utils/geo/street_image_provider/models.py 96.47% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #236      +/-   ##
===========================================
+ Coverage    87.59%   87.97%   +0.37%     
===========================================
  Files          212      215       +3     
  Lines        12987    13352     +365     
  Branches      1093     1138      +45     
===========================================
+ Hits         11376    11746     +370     
+ Misses        1218     1213       -5     
  Partials       393      393

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@ofr1tz ofr1tz mentioned this pull request Feb 24, 2026
Merged
9 tasks done
@ofr1tz
ofr1tz marked this pull request as ready for review February 24, 2026 17:42
@frozenhelium
frozenhelium requested a review from susilnem March 6, 2026 08:09
susilnem
susilnem previously requested changes Mar 11, 2026
View reviewed changes
Comment thread project_types/street/project.py Resolved
Comment thread utils/spatial_sampling.py Resolved
Comment thread utils/geo/street_image_provider/models.py Resolved
Comment thread utils/geo/street_image_provider/models.py Resolved
Comment thread project_types/street/api_calls.py Resolved
Comment thread apps/project/models.py Resolved
Comment thread project_types/street/project.py Resolved
@ofr1tz
ofr1tz force-pushed the feature/panoramax branch from 71352ae to f15f817 Compare March 19, 2026 15:50
@ofr1tz
ofr1tz requested a review from susilnem March 23, 2026 16:06
@ofr1tz
ofr1tz force-pushed the feature/panoramax branch 2 times, most recently from a2dad0a to f15f817 Compare March 23, 2026 16:53
tnagorra
tnagorra requested changes Apr 2, 2026
View reviewed changes
Comment thread apps/project/models.py Resolved
Comment thread project_types/street/api_calls.py Resolved
Comment thread schema.graphql Resolved
Comment thread schema.graphql Resolved
Comment thread schema.graphql Resolved
Comment thread project_types/street/project.py Resolved
tnagorra
tnagorra requested changes Apr 15, 2026
View reviewed changes
Comment thread project_types/street/api_calls.py Resolved
@ofr1tz
ofr1tz force-pushed the feature/panoramax branch from d4cb5bf to 5a5553c Compare April 29, 2026 08:44
@frozenhelium
frozenhelium force-pushed the feature/panoramax branch 2 times, most recently from bb79339 to c896b92 Compare November 3, 2026 12:47
ofr1tz and others added 5 commits November 3, 2026 18:33
@ofr1tz @frozenhelium
feat(street): add Panoramax as a street image provider
64e1a3a 
- Let street projects fetch images from Mapillary, Panoramax or a custom Panoramax instance
- Send the image provider to Firebase for projects and tutorials
- Replace the is_pano filter with pano_only
- Take the sampling threshold in meters instead of kilometers
- Convert Mapillary and Panoramax timestamps before filtering by capture time
- Allow 36 character firebase ids to fit Panoramax image ids
- Migrate existing street projects to the image provider config
@tnagorra @frozenhelium
fix(project): handle legacy shapes in street data migrations
e23d88f
@tnagorra @frozenhelium
fix(street): harden image fetching and filtering
ba5d824 
- Keep the Mapillary token out of errors and logs
- Report image provider request failures to the user
- Accept only the domain for custom Panoramax urls
- Ignore the organization id for Panoramax providers
- Normalize Panoramax picture type and timestamps
- Compare creator and organization ids as strings
- Ignore features without is_pano when filtering panoramas
- Keep images without a sequence in spatial sampling
- Remove unused image provider code
@tnagorra @frozenhelium
refactor(street): model street project specifics as a discriminated u…
49e23dd 
…nion

- Configure each image provider in its own field, selected by provider
- Migrate existing street projects to the new shape
- Accept only scheme and host for custom Panoramax urls
- Require an integer sampling threshold
- Describe Panoramax providers by catalog and instance
@tnagorra @frozenhelium
fix(project): make the street data migrations irreversible
99794f5 
- Make the street data migrations irreversible
- Assert the types and validity of migrated street projects
@tnagorra
tnagorra merged commit fc54063 into develop Nov 3, 2026
8 checks passed
@tnagorra
tnagorra deleted the feature/panoramax branch November 3, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tnagorra tnagorra tnagorra approved these changes
@frozenhelium frozenhelium frozenhelium approved these changes
@susilnem susilnem Awaiting requested review from susilnem

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ofr1tz @tnagorra @frozenhelium @susilnem