Repository navigation
Feature/panoramax - #74
Merged
Merged
Conversation
ofr1tz
marked this pull request as ready for review
February 24, 2026 17:42
frozenhelium
self-requested a review
March 6, 2026 07:58
frozenhelium
requested changes
Mar 12, 2026
Contributor
There was a problem hiding this comment.
Let's send the Enum value from the backend (main/graphql/enums.py) and use that instead of creating a separate enum on the client side. We can then receive and use it in the EnumContext. We should add custom panoramax option to StreetImageProviderNameEnum and only add url field to the custom option.
To summarize, let's change following in the backend
- In StreetImageProvider
- Add PANORAMAX_CUSTOM option
- Add pydantic validation to the StreetImageProvider.url
- Add StreetImageProviderNameEnum to ENUM_TO_STRAWBERRY_ENUMS (main/graphql/enum)
ofr1tz
force-pushed
the
feature/panoramax
branch
from
March 19, 2026 16:08
2610264 to
7ba77a9
Compare
frozenhelium
approved these changes
Apr 2, 2026
tnagorra
requested changes
Apr 15, 2026
| /> | ||
| {data.imageProvider?.url && ( | ||
| <TextOutput | ||
| label="Panoramax API URL" |
Contributor
There was a problem hiding this comment.
Is this label correct? How do we know the url is for Panoramax?
Contributor
Author
There was a problem hiding this comment.
The url field is only allowed for custom Panoramax API (see https://github.com/mapswipe/mapswipe-backend/blob/3089d827103cc40157930d0ff527ca93d0caa33f/utils/geo/street_image_provider/models.py#L28)
Contributor
There was a problem hiding this comment.
It's better to check the imageProvider type so that it does not break in the future.
| onChange={setFieldValue} | ||
| disabled={disabled} | ||
| hint="Provide a valid Mapillary organization ID to filter for images belonging to a specific organization. Empty indicates that no filter is set on organization." | ||
| hint="Provide a valid Mapillary organization ID to filter for images belonging to a specific organization. Empty indicates that no filter is set on organization (only Mapillary)." |
Contributor
There was a problem hiding this comment.
This should be a conditional field if it is only applicable for Mapillary.
| import TextInput from '#components/TextInput'; | ||
|
|
||
| import { PartialStreetMapillaryImageFiltersInputFields } from './schema'; | ||
| import { PartialStreetMapillaryImageFiltersInputFields } from './schema.ts'; |
Contributor
There was a problem hiding this comment.
We might also need to rename the variables?
e.g. PartialStreetMapillaryImageFiltersInputFields
7 of 9 tasks
ofr1tz
force-pushed
the
feature/panoramax
branch
from
September 3, 2026 15:58
70d5487 to
014b38e
Compare
tnagorra
force-pushed
the
feature/panoramax
branch
from
November 2, 2026 13:08
0f31109 to
ae83a38
Compare
- Let street projects use Mapillary, Panoramax or a custom Panoramax instance. - Accept only a scheme and host for the custom Panoramax instance URL. - Carry the common image filters over when switching providers. - Show the organization ID filter only for Mapillary. - Validate the sampling threshold as a non-negative integer in meters. - Show the image provider and its filters in project details. - Update the backend submodule. Co-authored-by: tnagorra <weathermist@gmail.com>
- Show the Panoramax viewer for Panoramax and custom instance projects. - Load the viewer lazily and show an error if it fails to load. - Load MapComplete pictures through the public Panoramax catalog. - Label the tutorial image ID field as a street-level image ID. Co-authored-by: tnagorra <weathermist@gmail.com>
frozenhelium
force-pushed
the
feature/panoramax
branch
from
November 3, 2026 13:04
ae83a38 to
3400f70
Compare
frozenhelium
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on mapswipe/mapswipe-backend#236
Changes
This introduces the possibility to create View Streets projects and tutorials with Panoramax as the image provider. Managers can choose to use either the federated Panoramax metacatalog, or a specific Panoramax instance (by providing the API url).
This PR doesn't introduce any:
console.logmeant for debugging