Repository navigation
Rely on installed package paths for internal dependencies #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
530dfac
Remove abstract base class for discovered path
meszarosrob abcf0e6
Add class to retrieve the installed package path
meszarosrob f86cbdd
Get the path of the required SQLite DB Integration plugin
meszarosrob 5f41e59
Get the path of the required WP CLI binary package
meszarosrob 54845c0
Move the exception docblocks to the interface
meszarosrob a520c6c
Use the suggested WP package path first, then discover it
meszarosrob 0030673
Add some tests for the Composer Package Path
meszarosrob 773b542
Ignore false positive escape output for exceptions
meszarosrob 893563f
Add unit test for WP CLI Path
meszarosrob 0ceb79f
Add unit tests for WordPress Path
meszarosrob 62064fb
Small cosmetic tweaks
meszarosrob c965581
Fix cs
meszarosrob ad10d98
Move data provider as last
meszarosrob 74157a9
Check for the concrete WP package and not the meta
meszarosrob 94c726f
Update test to look for the concrete WP package and not the meta
meszarosrob 70a7523
Add comment about the meta package
meszarosrob File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Syde\WpPhpUnitIntegration\Path; | ||
|
|
||
| use Composer\InstalledVersions; | ||
| use Exception; | ||
|
|
||
| class ComposerPackagePath | ||
| { | ||
| /** | ||
| * @throws Exception | ||
| */ | ||
| public function installPath(string $package): string | ||
| { | ||
| $installPath = InstalledVersions::getInstallPath($package); | ||
|
|
||
| if ($installPath === null) { | ||
| // phpcs:ignore WordPress.Security.EscapeOutput.ExceptionNotEscaped | ||
| throw new Exception("Package $package is not installed."); | ||
| } | ||
|
|
||
| $installRealPath = realpath($installPath); | ||
|
|
||
| if ($installRealPath === false) { | ||
| // phpcs:ignore WordPress.Security.EscapeOutput.ExceptionNotEscaped | ||
| throw new Exception("Can't determine real path of $package."); | ||
| } | ||
|
|
||
| return $installRealPath; | ||
| } | ||
| } |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.