Repository navigation
Rely on installed package paths for internal dependencies - #21
Merged
Merged
Conversation
strangerkir
reviewed
Oct 16, 2026
strangerkir
left a comment
There was a problem hiding this comment.
Thank you for implementing this!
I guess there is one issue that would be good to fix, otherwise all is fine.
strangerkir
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were multiple complaints related to the "auto discovery" feature, for example #18 and #7.
After a deeper look, prompted by the suggestion in #18, this PR removes the redundant "auto discovery" and instead relies on the installed package paths. This also reduces some of the complexity in the code.
Currently, we require both
wpackagist-plugin/sqlite-database-integrationandjohnpbloch/wp-cli-pharas "internal" dependencies, so they are guaranteed to be installed.wp-phpunit-integration/composer.json
Lines 18 to 24 in 1f9cd73
In general, we also suggest installing WordPress via Composer using
roots/wordpress, and all Syde projects follow this approach.wp-phpunit-integration/composer.json
Lines 35 to 37 in 1f9cd73
For WordPress, the "auto discovery" (finder) is kept only as a fallback in case
roots/wordpressis not found.Some of the possible caching optimisations for "auto discovery" were also removed to keep things simpler. If performance becomes a problem, we can later allow an explicit definition of the WordPress path once #17 is done. But this should not affect any Syde projects.