Repository navigation
Show the app's own 404 page, and know the explorer's own domains - #318
Merged
Merged
Conversation
The build writes a 404.html that hosts serve for a page that isn't there, so the explorer says "Page not found" in its own layout. The explorer's planned domains read their own network's node.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes ahead of moving the explorer to Cloudflare and its own domains (
explorer.dusk.network,explorer.testnet.dusk.network):404.html, which DigitalOcean and Cloudflare both serve for a missing page, so visitors see "Page not found" in the normal layout rather than the host's plain page. Tried in a browser with a server that behaves that way: status 404, the layout, and a working Home link.makeNodeUrlpicks the right node on those hostnames. Theapps.*ones keep working.Nothing changes on the live sites until the next deploy.