Repository navigation
Fix build failures on main [CLF-721] - #198
Merged
Merged
Conversation
PR #196 introduced Kotlin 2.2 multi-dollar string literals ($$"...") in ComposeLayoutInfo.kt and CompositionContexts.kt. The ktlint version pinned in this build (0.38.1 via ktlint-gradle 11.6.1) cannot parse that syntax, so `./gradlew build` has failed on main since that merge. Fork PRs only run the DCO check, so Android CI never caught it. Replace the literals with ordinary escaped strings that produce byte-identical values ("getChildren$ui", "<composer>$CompositionContextHolder", and "<composer>$CompositionContextImpl"). No dependency versions changed. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This was referenced Nov 4, 2026
handstandsam
approved these changes
Nov 4, 2026
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
./gradlew buildhas been failing onmainsince #196 merged. This PR makes the existing code pass the existing checks; no dependency versions are changed.Why main was red
#196 (Compose 1.11.1 upgrade) came from a fork, and the Android workflow only runs on
pull_request/merge_groupfrom the main repo, so that PR only got the DCO check and its code was never built by CI.Failures and fixes
:radiography:runKtlintCheckOverMainSourceSet— "KtLint failed to parse file ComposeLayoutInfo.kt" (289:66 Expecting an expression). #196 introduced Kotlin 2.2 multi-dollar string literals ($$"...") inComposeLayoutInfo.ktandCompositionContexts.kt, which the ktlint version pinned in this build (0.38.1) can't parse.getChildren$ui,<composer>$CompositionContextHolder,<composer>$CompositionContextImpl), so the reflection lookups are unchanged.That was the only failure: with
--continue, every other task (compile, unit tests, lint, apiCheck) passed on an unmodifiedmain.Verification
./gradlew buildpasses locally../gradlew connectedCheckpasses on a physical Samsung SM-A256U1 (Android 16): 43 instrumented tests acrossradiography,compose-tests,compose-unsupported-tests,sample, andsample-compose, 0 failures.Linear: CLF-721
🤖 Generated with Claude Code