Repository navigation
Upgrade Compose to 1.12.1 [CLF-720] - #199
Merged
Merged
Conversation
zach-klippenstein
force-pushed
the
zachklipp/compose-1-12-a559f8
branch
from
November 4, 2026 00:56
428f113 to
757f5e8
Compare
zach-klippenstein
changed the base branch from
main
to
zachklipp/fix-main-ci-c61e01
November 4, 2026 00:56
zach-klippenstein
changed the base branch from
main
to
zachklipp/radiography-ktlint-ktfmt-cfa2a9
November 4, 2026 01:24
Compose 1.12.x publishes AAR metadata requiring AGP 9.1.0+ and compileSdk 37, so this also bumps AGP to 9.1.1 and the Gradle wrapper to 9.3.1, opts out of AGP 9's built-in Kotlin / new DSL to keep the standalone Kotlin plugin, moves library targetSdk to testOptions (removed from defaultConfig in AGP 9), and raises compileSdk/JVM target only in the two Compose test modules. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
zach-klippenstein
force-pushed
the
zachklipp/compose-1-12-a559f8
branch
from
November 4, 2026 01:26
757f5e8 to
ea1e005
Compare
joshfriend
approved these changes
Nov 4, 2026
Base automatically changed from
zachklipp/radiography-ktlint-ktfmt-cfa2a9
to
main
November 4, 2026 01:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the Compose version Radiography compiles and tests against from 1.11.1 to 1.12.1 (latest stable on Google Maven), ahead of the 2.11 release. Companion to #197 (Kotlin 2.4.21).
Required transitive bumps
Compose 1.12.0 and 1.12.1 both ship AAR metadata with
minCompileSdk=37andminAndroidGradlePluginVersion=9.1.0(1.11.4 was 35 / 8.6.0). AGP enforces this on thecompose-testsandcompose-unsupported-testsandroidTest APKs, so these can't be avoided:android.builtInKotlin=false/android.newDsl=falseingradle.propertiesso the standaloneorg.jetbrains.kotlin.androidplugin keeps working under AGP 9. Migrating to AGP's built-in Kotlin is left as a follow-up; AGP prints deprecation warnings for these flags but the build is green.defaultConfig.targetSdkwas removed for library modules in AGP 9 → moved totestOptions.targetSdk = 35inradiography,compose-tests,compose-unsupported-tests. Behaviour of the test APKs is unchanged.compileSdk = 37and JVM target 11 only incompose-testsandcompose-unsupported-tests. Compose 1.12's test artifacts contain inline functions compiled for JVM 11. The publishedradiographylibrary stays at compileSdk 35 / JVM 1.8 (its Compose deps arecompileOnly), so nothing changes for consumers.No Kotlin bump was needed (2.3.10 works with AGP 9.1.1).
Reflection / scanning code
No changes were required in
CompositionContexts.ktorComposeLayoutInfo.ktfor 1.12: theGapComposer/LinkComposer/RememberObserverHolderhandling from #196 still resolves.This branch is based on #200 (ktlint → ktfmt migration), so it is temporarily targeted at that branch; once #200 merges it will be rebased onto
main.Expected test output
No expected-output changes. All 34
compose-testscases, thecompose-unsupported-testscase, and theradiography,sample,sample-compose, andstoic-plugininstrumented tests pass unchanged on a Samsung SM-A256U1 (Android 16). Compose 1.12 did not rename any of the internal groups the tests assert on../gradlew build(unit tests, lint, ktlint, apiCheck) is green; no.apichanges.Linear: CLF-720
🤖 Generated with Claude Code