Repository navigation
Conversation
Acriss
marked this pull request as draft
November 18, 2026 13:44
setup-java took the JDK preinstalled on the ubuntu-24.04 and windows-2025 runners whenever it matched the requested version, without asking Adoptium. CI now names the exact Temurin build (25.0.5+8), which setup-java installs or fails on: a wheel can no longer bundle another build with the same version numbers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Acriss
force-pushed
the
security/java4shell-stopgap
branch
from
November 19, 2026 14:29
cda0ab0 to
a83d16d
Compare
`JAVA_VERSION` keeps the first 3 numbers of the JDK version, taken from the package version: its fourth number counts the jdk4py releases of the line. `JAVA_FULL_VERSION` is the exact JDK version with its build number, such as 25.0.5.1+2. jlink only keeps the version without the build number in the `release` file it writes, so `build_java_runtime.py` copies `JAVA_RUNTIME_VERSION` from the source JDK's `release` file with `--release-info`. `JAVA_FULL_VERSION` reads it on first access and drops the optional suffix, such as `-LTS`. The README documents what each version number means and which JDK build each release bundles. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JDK 25.0.5.1 fixes CVE-2026-114938 ("Java4Shell"). It is released as jdk4py 25.0.5.1: `JAVA_VERSION` is `(25, 0, 5)` and `JAVA_FULL_VERSION` is `"25.0.5.1+2"`. CI bundles Temurin 25.0.5.1+2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Acriss
force-pushed
the
security/java4shell-stopgap
branch
from
November 19, 2026 15:24
a83d16d to
353598b
Compare
Acriss
marked this pull request as ready for review
November 20, 2026 13:36
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CVE-2026-114938 ("Java4Shell", CISA alert, write-up): on x86-64 CPUs with AVX-512 VBMI (Intel Ice Lake and later, AMD Zen 4 and later), the HotSpot Base64 decoding intrinsic writes past the end of its output array on malformed input such as 64
Afollowed by=. The researchers reached unauthenticated remote code execution through ordinary features such as HTTP Basic authentication.OpenJDK fixed it in 25.0.5.1 (advisory), along with 9 other CVEs.
What
Three commits:
ci.yamlnames the build in full (TEMURIN_VERSION). Before, a request for25.0.5was served from the JDK preinstalled on theubuntu-24.04andwindows-2025runners (Resolved Java 25.0.5+8 from tool-cache), without asking Adoptium. With an exact build,setup-javainstalls that build or fails with "version not found".JAVA_FULL_VERSION. The version scheme keeps its 4 numbers: the first 3 are the JDK line (JAVA_VERSION, unchanged), the fourth counts the jdk4py releases in that line.JAVA_FULL_VERSIONis the exact JDK version with its build number, as a string such as"25.0.5.1+2". jlink drops the build number from thereleasefile it writes, sobuild_java_runtime.pycopiesJAVA_RUNTIME_VERSIONfrom the source JDK with--release-info, andJAVA_FULL_VERSIONreads it back without the-LTSsuffix. The README explains the numbers and maps each release to its JDK build.25.0.5.1, built from Temurin25.0.5.1+2.JAVA_VERSIONstays a 3-tuple, so nothing changes for code that reads it.Tested
pytest(7 passed, withJAVA_VERSION == (25, 0, 5)andJAVA_FULL_VERSION == "25.0.5.1+2", checked against the(build ...)line ofjava -version).25.0.5+100000002.0.LTS(25.0.5.1+2) from Adoptium,pytestpasses (7 tests), and the wheel'sjava -versionprintsTemurin-25.0.5.1+2.setup-javawithNo matching version found for SemVer '25.0.5+1.2', rather than falling back to the JDK preinstalled on the runner.Merging publishes
25.0.5.1to PyPI.🤖 Generated with Claude Code