Repository navigation
Conversation
The 21 line's workflows can no longer run: the repository now requires every action used by a workflow to be locked in `.github/workflows/actions.lock`, and the lockfile cannot cover local actions. Its local actions and reusable workflows are folded into one `ci.yaml`, laid out like `main`'s and with its action versions, with the Conda build added to each platform job. - PyPI trusts `ci.yaml` in the `pypi` environment, so this file publishes the wheels on a push to `21`, and skips a version that PyPI already has. - The Conda channel credentials were removed with Conda support on `main`, so the Conda packages are kept as artifacts of the run, to be uploaded by hand. - The Linux ARM build moves to the standard `ubuntu-24.04-arm` runner, as on `main`. - CI asks setup-java for the first 3 numbers of the JDK version, which resolve to the newest Temurin build of that update, 4-number ones included. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Acriss
marked this pull request as ready for review
November 18, 2026 14:22
setup-java took the JDK preinstalled on the ubuntu-24.04 and windows-2025 runners whenever it matched the requested version, without asking Adoptium. Requesting the exact build (for instance 25.0.5.1+2) makes it install that build or fail, so a wheel can no longer bundle another build that shares the same version numbers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The 21 line no longer releases Conda packages, like `main` since #97: remove the Conda build from CI, the Conda recipe, and the Conda install instructions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Temurin build is now written in full in `ci.yaml` (21.0.8+9) instead of being derived from the package version and a build number. The package version no longer has to spell out the whole JDK version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Acriss
commented
Nov 19, 2026
Comment on lines
-13
to
-18
| or as a Conda package: | ||
|
|
||
| ```bash | ||
| conda config --add channels https://conda.atoti.io | ||
| conda install jdk4py | ||
| ``` |
Author
There was a problem hiding this comment.
Removing the doc: we don't publish it no more, so let's not mention it.
Else users will ask why it's not being updated there.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The 21 line (jdk4py 21.x) can no longer build or publish:
.github/workflows/actions.lock. The lockfile cannot cover local actions, so the 21 line's workflows, built from 4 local actions and 2 reusable workflows, fail at startup.publish.yamlpublishes from thedeploymentenvironment with Conda channel secrets, and both were removed with Conda support onmain(Drop Conda, add a jdk4py command, and upgrade to JDK 25.0.5 #97).This is needed to release 21.0.13.1 (#100) once Temurin publishes JDK 21.0.13.1.
What
The 21 line follows
mainon CI and packaging. The package code stays at 21.0.8.2.ci.yaml, laid out likemain's and with its action versions, plus the lockfile generated bygh actions-lock.main: the 21 line drops Conda likemaindid in Drop Conda, add a jdk4py command, and upgrade to JDK 25.0.5 #97. The Conda build, the Conda recipe and the Conda install instructions are removed, and only the wheels are published.ci.yamlin thepypienvironment, so this file publishes the wheels on a push to21. It skips a version that PyPI already has, so merging this PR (which keeps 21.0.8.2) publishes nothing.ubuntu-24.04-armrunner, as onmain.setup-javagets21.0.8+9, named in full by a newTEMURIN_VERSIONvalue inci.yaml, to bump with the version. Before, a request for a bare version was served from the JDK preinstalled on theubuntu-24.04andwindows-2025runners whenever it matched, without asking Adoptium. With an exact build,setup-javainstalls that build or fails. This matters for 21.0.13.1 (Upgrade to JDK 21.0.13.1 to fix CVE-2026-114938, add a variable containing the full JDK build version #100), which shares its first 3 numbers with the 21.0.13+9 preinstalled on those runners.Before merging
The
pypienvironment deploys only from protected branches, so21needs protecting before the next release from it.Tested
21.0.8+9from Adoptium.gh actions-lock --no-fixreports the workflow valid, and the version check skips 21.0.8.2 (on PyPI) and publishes 21.0.13.1 (absent).🤖 Generated with Claude Code