Repository navigation
build: bump libgit2 to include the WinHTTP Basic fallback STUD-81431 - #32
Merged
daniel-dumitrascu merged 2 commits intoOct 12, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Epixa-Dogfood ReviewReview unavailable: Not reviewed: What this PR doesThe pull request author describes the intended change as follows: build: bump libgit2 to include the WinHTTP Basic fallback STUD-81431 This review did not reuse a local review of this change. Set up Epixa local review. Full review: b94b736 |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the
libgit2submodule from7ba43f8d2to0c0dd3ddd, the currentdevelopof UiPath/libgit2 (merge of UiPath/libgit2#18). This brings in the fix for clone/fetch/push over HTTPS failing on the WinHTTP build against GitHub Enterprise Managed Users organisations withfailed to parse supported auth schemes: The operation identifier is not valid.A second commit moves the win-arm64 CI build to the VS 2026 Arm runner, because GitHub's
windows-11-armimage no longer has VS 2022 (see below).Jira: STUD-81431
What the bump brings in
0686dcc04583df2c04CONST_STRLEN8ba8aa9da,67cd24a46The only source change is
src/libgit2/transports/winhttp.c(+30 −2). It is compiled only into the Windows WinHTTP variants (libgit2.dll,libgit2_ssh.dll). The Schannel variants and the posix builds don't compilewinhttp.c.The submodule change is pointer-only, like
09377dc. GitHub's submodule view lists the fork's.github/workflows/*.ymlfiles, but they belong to the fork; this repo's YAML changes only in the second commit below.CI: win-arm64 runner (second commit)
The
win-arm64build started failing at cmake configure withGenerator Visual Studio 17 2022 could not find any instance of Visual Studio. GitHub now serves thewindows-11-armlabel with thewindows-11-vs2026-arm64image, which has only VS 2026. The v9 release build on 2026-09-21 still got the VS 2022 image, and a re-run failed the same way.The second commit pins the arm64 leg to
windows-11-vs2026-arm, GitHub's explicit label for that image, with theVisual Studio 18 2026generator. The image ships CMake 4.4.4, which supports that generator.windows-2022/ VS 2022, so its DLLs are built as before.This is in the same PR on purpose:
build.ymlpublishes a release on anydeveloppush that touches the workflow, so a separate CI-only PR would mint its ownnatives-1.9.1-v10without the fix.Release
On merge,
build.ymlpublishes thenatives-1.9.1-v<N>release, expectednatives-1.9.1-v10.Testing
All of the following used DLLs built from
583df2c04, which has an identical tree to0c0dd3ddd:build.libgit2.ps1 -vs '17 2022' -Platform win-x64, the same settings as CI. All four Windows variants built, and the HTTPS-backend assertions pass.1.9.1-v9and against the new DLLs, using a local smart-HTTP server, an HTTPS server and a forward proxy:git-upload-packandgit-receive-pack, and the process loadedlibgit2.dllfrom the new build.Follow-up
natives.lock.jsonto the newnatives-1.9.1-v<N>release, like chore: bump native binaries pin to natives-1.9.1-v9 STUD-81430 libgit2sharp#32.LibGit2Sharp.UiPath 1.9.1-v<N>to the internal feed.LibGit2Sharp.UiPathinDirectory.Build.studio.targets.🤖 Generated with Claude Code