Skip to content

fix: reject client-controlled PD KV transport params #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hiworldwzj merged 1 commit into from
Nov 14, 2026
Merged

fix: reject client-controlled PD KV transport params #1725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lightllm/server/core/objs/sampling_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,8 +399,8 @@ def init(self, tokenizer, **kwargs):
self.exponential_decay_length_penalty = ExponentialDecayLengthPenalty()
self.exponential_decay_length_penalty.initialize(kwargs.get("exponential_decay_length_penalty", (1, 1.0)))

# The trusted PD manager populates this field after request parsing.
self.pd_kv_trans_params = PDKVTransParamObj()
self.pd_kv_trans_params.set(kwargs.get("pd_kv_trans_params", None))
self.pd_master_node_id = NodeUUId()
self.pd_master_node_id.initialize(kwargs.get("pd_master_node_id", 0))

Expand Down
15 changes: 12 additions & 3 deletions unit_tests/server/core/objs/test_sampling_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,6 @@ def test_node_uuid_initialization():
def test_sampling_params_initialization():
params = SamplingParams()
pd_master_node_id = 12345678901234567890
pd_kv_trans_params = b"pd-kv-transport-params"
data = {
"best_of": 2,
"n": 2,
Expand All @@ -176,7 +175,6 @@ def test_sampling_params_initialization():
"stop_sequences": [[2, 1], [3, 4]],
"exponential_decay_length_penalty": (1, 1.0),
"pd_master_node_id": pd_master_node_id,
"pd_kv_trans_params": pd_kv_trans_params,
}
params.init(None, **data)

Expand All @@ -187,7 +185,18 @@ def test_sampling_params_initialization():
assert params.temperature == 1.0
assert params.stop_sequences.size == 2
assert params.pd_master_node_id.get() == pd_master_node_id
assert params.pd_kv_trans_params.get() == pd_kv_trans_params


def test_client_cannot_set_pd_kv_trans_params():
params = SamplingParams()
params.init(None, pd_kv_trans_params="AAAAdeadbeefBBBB")

assert params.pd_kv_trans_params.data_len == 0
assert params.pd_kv_trans_params.get() == b""

trusted_pd_data = b"pd-kv-transport-params"
params.pd_kv_trans_params.set(trusted_pd_data)
assert params.pd_kv_trans_params.get() == trusted_pd_data


@pytest.mark.parametrize(
Expand Down
Loading