Repository navigation
fix: reject client-controlled PD KV transport params - #1725
Merged
hiworldwzj merged 1 commit intoNov 14, 2026
Merged
hiworldwzj merged 1 commit into
hiworldwzj merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1629
Issue: #1629
Summary
Prevent public request parameters from populating the internal PD KV transport field. That field is later deserialized by the inference loop and must only be written by the trusted PD manager.
The regression test verifies that a client-supplied value is ignored while trusted transport data can still be assigned through the existing internal setter.
Test plan
python -m pytest -q unit_tests/server/core/objs/test_sampling_params.py(34 passed)