Skip to content

Restore lazy transactions after the replay's COPY - #569

Open
erikrozendaal wants to merge 1 commit into
masterfrom
improvement/lazy-transactions-after-copy
Open

erikrozendaal wants to merge 1 commit into
masterfrom
improvement/lazy-transactions-after-copy

Conversation

@erikrozendaal

Copy link
Copy Markdown
Member

The ReplayOptimizedPostgresPersistor takes the raw connection for its COPY, and ActiveRecord then disables lazy transactions on that connection for good, since it cannot know what is done with it. Every later transaction on the connection sends BEGIN and COMMIT, also one that runs no query, so whether code outside the replay does so depends on whether a replay ran earlier on the same connection. A COPY leaves the connection's state alone, so the persistor now puts lazy transactions back to what they were once the COPY is done or has failed; the open transaction stays materialized either way. This relies on ActiveRecord's transaction_manager and enable_lazy_transactions!, both public methods marked :nodoc:.

Taking the raw connection for the COPY disables ActiveRecord's lazy
transactions on that connection for good, since ActiveRecord cannot know
what is done with it. From then on every transaction on the connection
sends BEGIN and COMMIT, also one that runs no query, and whether code
outside the replay does so depends on whether a replay ran before it on
the same connection. A COPY leaves the connection as it was, so the
persistor sets lazy transactions back to what they were once the COPY is
done or has failed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant