Repository navigation
Restore lazy transactions after the replay's COPY - #569
Open
erikrozendaal wants to merge 1 commit into
Open
erikrozendaal wants to merge 1 commit into
erikrozendaal wants to merge 1 commit into
Conversation
Taking the raw connection for the COPY disables ActiveRecord's lazy transactions on that connection for good, since ActiveRecord cannot know what is done with it. From then on every transaction on the connection sends BEGIN and COMMIT, also one that runs no query, and whether code outside the replay does so depends on whether a replay ran before it on the same connection. A COPY leaves the connection as it was, so the persistor sets lazy transactions back to what they were once the COPY is done or has failed.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ReplayOptimizedPostgresPersistor takes the raw connection for its COPY, and ActiveRecord then disables lazy transactions on that connection for good, since it cannot know what is done with it. Every later transaction on the connection sends BEGIN and COMMIT, also one that runs no query, so whether code outside the replay does so depends on whether a replay ran earlier on the same connection. A COPY leaves the connection's state alone, so the persistor now puts lazy transactions back to what they were once the COPY is done or has failed; the open transaction stays materialized either way. This relies on ActiveRecord's transaction_manager and enable_lazy_transactions!, both public methods marked :nodoc:.