Repository navigation
Prepare v3 documentation and consistent CI publication - #15
Conversation
|
@codex a review please. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f95ee60a0b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
autocarl
left a comment
autocarl
left a comment
There was a problem hiding this comment.
Review summary
Changes requested for three release-readiness issues. Two additional findings are inline below; the existing tc://guide indentation finding is also confirmed by a live MCP resources/read probe: price is returned with one leading tab and renders as a child of description.
I otherwise verified the immutable checkout/artifact path, the release-version guard, matching and mismatching package-version cases, the downloaded portable archive, NuGet README identity, C# usage examples on net8.0/net10.0, and the Release test suite (71 non-API passes; 12 credential-dependent skips). actionlint 1.7.12 is clean and the hosted checks are green for the reviewed head.
autocarl
left a comment
autocarl
left a comment
There was a problem hiding this comment.
Supplemental review findings
An independent CI/security and MCP-contract pass found three additional issues, each reproduced against this head. I also expanded the existing tc://guide thread separately with the confirmed wire-contract mismatch.
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Prepare the documentation and publication workflow for a future 3.0 stable release. This PR does not bump the version, create a release branch, or publish a stable release.
Release workflow change
Release branches must contain a reviewed stable version before they are pushed. CI no longer changes
version.jsonor pushes a versioning commit during the build, preventing packages and binaries from being built from different commits.Existing publishing policy is retained: pushes to
masterpublish prereleases; pushes torelease/**publish stable releases. Pull requests do not publish. A stable release-branch push remains a separate, explicit decision.Validation
actionlintand PowerShell parsing passed. Local checks exercised the release-version guard, publication dependencies, shared version, pinned checkouts/tag target, and acceptance/rejection of matching/mismatched package versions.The authenticated run returned 80 passes and 3 failures with TenantCloud's
Too Many Attemptsresponse. API limitations and their fixes remain outside this PR. No fresh macOS execution is claimed; the release checklist links the existing macOS validation separately. The GitHub-hosted workflow still needs to run on this PR.