Repository navigation
fix: judge a snapshot SBOM by the newest release of its line - #9805
Merged
Merged
Conversation
25.3-SNAPSHOT compared as the start of the 25.3 line, so a cve-status verdict saying a fix shipped in 25.3.5 did not apply to it. The SBOM run of #9804 was red on Quill CVE-2025-15056 for that reason. A snapshot is now judged as prev.lastPatch, the newest release of its line, which the same script already computes for the comparison. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Dependencies Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #9799.
What was wrong. The cve-status check compared a snapshot build as the bare line, so
25.3-SNAPSHOTcounted as25.3, which is before any patch. A cve-status verdict such as "fixed from 25.3.5" (>=25.3.5,<25.4) therefore did not apply, and the risk verdict for<25.3.5matched instead. That is why the backport's SBOM run, https://github.com/vaadin/platform/actions/runs/41637731164, went red on Quill CVE-2025-15056.The fix. A snapshot is now judged as
prev.lastPatch, the newest release of its line. The script already computes it for the dependency comparison:25.3-SNAPSHOTis judged as25.3.5;25.4-SNAPSHOTis judged as25.4.0-alpha4.When a line has no release yet, the build version is used, as before.
On main this changes nothing today: 25.4.0-alpha4 still carries the Quill risk, which is correct.
Related to #9804
🤖 Generated with Claude Code