Skip to content

feat(stovepipe): Wire build analysis pipeline - #909

Merged
prathshenoy merged 2 commits into
codex/stovepipe-buildanalysis-controllerfrom
codex/stovepipe-buildanalysis-wiring
Oct 22, 2026
Merged

feat(stovepipe): Wire build analysis pipeline#909
prathshenoy merged 2 commits into
codex/stovepipe-buildanalysis-controllerfrom
codex/stovepipe-buildanalysis-wiring

Conversation

@prathshenoy

@prathshenoy prathshenoy commented Oct 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

What:

  • Connect build analysis to build-start and completion notifications, using a no-op detector in the reference service while keeping result recording independent.
  • Configure bounded analysis retries and connect dead-letter recovery that records incomplete analysis without rerunning detection.

Why:

  • Keep result recording independent of issue detection while allowing deployments to provide real detection.

Test Plan

  • Add unit tests.
  • Verify the reference service integration with its default detector.

Revert Plan

  • Revert this PR. No schema changes need reversal, and existing observations can remain stored without affecting prior build processing.

Issue Links

Stack

  1. feat(stovepipe): Persist build issue observations #902
  2. feat(stovepipe): Add build analysis polling #907
  3. feat(stovepipe): Record incomplete build analysis #915
  4. feat(stovepipe): Wire build analysis pipeline #909
  5. feat(stovepipe): Store currently open issues #916

This was referenced Oct 21, 2026
Merged
Merged
@prathshenoy
prathshenoy force-pushed the codex/stovepipe-buildanalysis-wiring branch 3 times, most recently from 31fae0b to bff07ae Compare October 22, 2026 00:20
@prathshenoy prathshenoy changed the title feat(stovepipe): Wire optional build analysis feat(stovepipe): Wire build analysis pipeline Oct 22, 2026
@prathshenoy
prathshenoy force-pushed the codex/stovepipe-buildanalysis-wiring branch from bff07ae to b81aae1 Compare October 22, 2026 00:39
@prathshenoy
prathshenoy force-pushed the codex/stovepipe-buildanalysis-wiring branch 2 times, most recently from 64ed398 to e657d69 Compare October 22, 2026 03:20
@prathshenoy
prathshenoy force-pushed the codex/stovepipe-buildanalysis-wiring branch from e657d69 to a857899 Compare October 22, 2026 03:36
@prathshenoy
prathshenoy force-pushed the codex/stovepipe-buildanalysis-wiring branch 2 times, most recently from beb6b3d to 0df65b2 Compare October 22, 2026 03:59
@prathshenoy prathshenoy mentioned this pull request Oct 22, 2026
Merged
1 task done
@prathshenoy
prathshenoy force-pushed the codex/stovepipe-buildanalysis-wiring branch from 0df65b2 to 1d44584 Compare October 22, 2026 04:08
@prathshenoy
prathshenoy changed the base branch from codex/stovepipe-buildanalysis-controller to codex/stovepipe-buildanalysis-recovery October 22, 2026 04:08
@prathshenoy prathshenoy mentioned this pull request Oct 22, 2026
Merged
2 tasks done
@prathshenoy
prathshenoy added this pull request to stack #920 October 22, 2026 13:25
@prathshenoy
prathshenoy marked this pull request as ready for review October 22, 2026 13:28
mnoah1
mnoah1 approved these changes Oct 22, 2026
View reviewed changes

@mnoah1 mnoah1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comment below regarding errs.Group before merging.

Comment thread stovepipe/controller/build/build.go Outdated
@prathshenoy
prathshenoy force-pushed the codex/stovepipe-buildanalysis-wiring branch from 1d44584 to d905685 Compare October 22, 2026 14:50
@prathshenoy
prathshenoy enabled stacked auto-merge October 22, 2026 15:03
@prathshenoy
prathshenoy added this pull request to the merge queue Oct 22, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue because a pull request earlier in the stack was removed Oct 22, 2026
@prathshenoy
prathshenoy force-pushed the codex/stovepipe-buildanalysis-wiring branch from d905685 to 62c8e8a Compare October 22, 2026 15:21
@prathshenoy
prathshenoy added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit 0ef1667 Oct 22, 2026
21 checks passed
Base automatically changed from codex/stovepipe-buildanalysis-recovery to codex/stovepipe-buildanalysis-controller October 22, 2026 15:57
@prathshenoy
prathshenoy deleted the codex/stovepipe-buildanalysis-wiring branch October 22, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mnoah1 mnoah1 mnoah1 approved these changes
@behinddwalls behinddwalls Awaiting requested review from behinddwalls behinddwalls is a code owner
@sbalabanov sbalabanov Awaiting requested review from sbalabanov sbalabanov is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@prathshenoy @mnoah1