Skip to content

feat(json-schema-document): render document info and definitions - #11119

Draft
robert-hebel-sb wants to merge 1 commit into
feat/json-schema-2020-12-number-formatsfrom
feat/json-schema-2020-12-get-type
Draft

robert-hebel-sb wants to merge 1 commit into
feat/json-schema-2020-12-number-formatsfrom
feat/json-schema-2020-12-get-type

Conversation

@robert-hebel-sb

@robert-hebel-sb robert-hebel-sb commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Description

Render the header of a standalone JSON Schema document (JSONSchemaDocumentInfo: document name as heading, dialect and document-kind stamps, base/retrieval URIs and description) and its definitions (JSONSchemaDocumentDefinitions), wired into JSONSchemaDocument, with styles.

Part 5 of 5 of a stack on top of #11117 (standalone JSON Schema 2020-12).

Motivation and Context

Completes the document-level rendering of a standalone JSON Schema document. The stack is blocked until the swagger-client release it needs is published.

How Has This Been Tested?

  • Unit tests (npm run test:unit -- test/unit/core/plugins/json-schema-document) and ESLint on the plugin and its tests passed locally before the tarballs were removed from package.json.
  • Playwright specs for the header and definitions are included; they were not run.
  • Not re-run against the released swagger-client (the tarballs are dropped in feat(json-schema-document): render standalone JSON Schema 2020-12 #11117); CI is expected to fail until the release this stack depends on is published.

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@robert-hebel-sb
robert-hebel-sb force-pushed the feat/json-schema-2020-12-get-type branch from bf75c66 to f024821 Compare October 28, 2026 12:31
@robert-hebel-sb
robert-hebel-sb marked this pull request as draft October 28, 2026 12:32
@robert-hebel-sb robert-hebel-sb changed the title Feat/json schema 2020 12 get type feat(json-schema-document): render document info and definitions Oct 28, 2026
@robert-hebel-sb
robert-hebel-sb changed the base branch from feat/json-schema-2020-12-detection to feat/json-schema-2020-12-number-formats October 28, 2026 12:33
@robert-hebel-sb
robert-hebel-sb force-pushed the feat/json-schema-2020-12-get-type branch from f024821 to d2bb866 Compare October 28, 2026 12:36
@robert-hebel-sb
robert-hebel-sb force-pushed the feat/json-schema-2020-12-get-type branch from d2bb866 to 0db6fdd Compare October 28, 2026 12:38
Add JSONSchemaDocumentInfo and JSONSchemaDocumentDefinitions components,
wire them into JSONSchemaDocument and update styles and tests.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@robert-hebel-sb
robert-hebel-sb force-pushed the feat/json-schema-2020-12-get-type branch from 0db6fdd to 1fa9804 Compare October 29, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant