Skip to content

docs: ADR-0024 supersedes ADR-0022 and ADR-0023 on review passes - #93

Open
svozza wants to merge 2 commits into
mainfrom
adr-0024-review-passes
Open

svozza wants to merge 2 commits into
mainfrom
adr-0024-review-passes

Conversation

@svozza

@svozza svozza commented Nov 12, 2026

Copy link
Copy Markdown
Owner

What this does

Adds ADR-0024, which supersedes ADR-0022, its addendum, and ADR-0023, so the multi-pass review decision is stated once.

  • ADR-0022 rested on figures from a harness whose search tool failed on every call; its addendum re-measured them; ADR-0023 then made the pass a count without restating what a pass is. ADR-0024 restates the whole decision on measurements taken with search working and review prompt v6.
  • It records one new result: partitioning the first pass between two reviewers, then running later passes over their union, measured against the pass loop at equal session counts.
  • The three superseded files each get a single SUPERSEDED by ADR-0024 marker under the title. Nothing else in them changes.
  • Comments in review_passes.py, the review workflow and the architecture diagram now cite ADR-0024.

No behaviour changes.

The new measurement

8 public pull requests of 2,300-3,900 changed lines, 4 runs each, Opus 5.5 at high effort on prompt v6, blind judge reading source. Supported defect families per pull request:

Sessions Pass loop Partitioned
2 10.2 9.1
3 12.9 12.3
4 15.1 (earlier batch) 15.3

Partitioning is behind on 7 of 8 pull requests at two and at three sessions (differences -1.1 and -0.6, both intervals include zero), and 15 to 30% cheaper. 351 of 353 partition findings were supported.

For review

The prose of docs/adr/0024-a-review-is-up-to-four-passes-each-shown-what-came-before.md.

🤖 Generated with Claude Code

States the multi-pass decision once, on measurements taken with search
working and prompt v6, and records partitioning against the pass loop at
equal session counts (behind on 7 of 8 pull requests at 2 and at 3 sessions).
The superseded records carry a marker; code and workflow comments point at
ADR-0024.
@svozza
svozza deployed to ai-pr-review-runtime November 12, 2026 07:25 — with GitHub Actions Active
@svozza
svozza deployed to ai-pr-review-runtime November 12, 2026 07:30 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
ai-pr-review-runtime — 5af7401a Deployed Nov 12, 2026 by svozza via evals #212
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant