Repository navigation
feat: the second pass starts from the kinds of defect the first did not report - #91
Merged
Merged
Conversation
…ot report SECOND_PASS_NOTE told the second pass to start with changed files and behaviours the first pass did not touch. It now names defect kinds first (error paths, edge cases, compatibility for existing callers, concurrency, tests that cannot fail), then files and behaviours. Measured on prompt v6 against the current note, both arms shown the same first review. New supported families added per second pass: - 18 PRs of 250-1,500 changed lines, two batches: +0.31 and +0.26 (1.42 -> 1.69 pooled, 90% interval -0.01 to +0.57); 192 of 192 supported. - 8 held-out PRs of 2,300-3,900 lines, 6 runs each: 2.69 -> 3.46, +0.77 (+0.48 to +1.10), up on 7 and level on 1; 181 of 183 supported against 148 of 148; cost $1.93 -> $1.98.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
One sentence of
SECOND_PASS_NOTEinsrc/aceiro/review_passes.py, the harness-authored instruction given to the opt-in second review pass (ADR-0022).Before: "look for confirmed defects that pass missed, starting with changed files and behaviours it did not touch."
After: "look for confirmed defects that pass missed. Start with the kinds of defect it did not report (error paths, edge cases, compatibility for existing callers, concurrency, tests that cannot fail) and with changed files and behaviours it did not touch."
The main review prompt is untouched. The second pass stays off by default.
Evidence
Opus 5.5 at high effort on prompt v6, source-only tools. Both arms of a comparison are shown the same first review. Blind judge (Fable 5) reading source. The figure is new supported defect families the second pass adds beyond the first review; paired by PR, 90% bootstrap interval over PRs.
On the large PRs:
Checks
Not measured
🤖 Generated with Claude Code