Repository navigation
feat: the reviewer settles a suspicion instead of parking it (prompt v6) - #89
Merged
Merged
Conversation
A suspected problem was sent to residual_risk when it could not be confirmed. The prompt now says to read the code that settles it and report it once confirmed; residual_risk keeps only what the tools cannot settle. Measured on 18 public PRs of 250-1,500 changed lines against a concurrent control, twice: +0.32 and +0.48 supported defect families per review (3.2 -> 3.6), 406 of 410 findings supported, cost +6%.
grouped_cross_file_defect required a finding on the removed constant to share the callers' group and capped the review at 3 findings. Prompt v6 also reports the removal as a breaking change for outside importers, with its own remedy, and failed the scenario in 3 of 9 runs (v5: 0 of 8). The callers must still share one group, and nothing unrelated may join it. Ceiling raised to 4.
svozza
force-pushed
the
prompt-pursue
branch
from
November 10, 2026 21:43
201b80c to
2f8b4b3
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
One sentence of
prompts/ai-pr-review.md, and the version marker (5 -> 6).Before: "If you suspect a problem but cannot confirm it with the tools available, put one short note in
residual_riskinstead of a finding."After: "If you suspect a problem, do not drop it: read the code that settles it, and report it as a finding once it is confirmed. Only what the tools available cannot settle goes in
residual_risk, as one short note."The "confirmed defects only" mandate is unchanged.
Evidence
18 public PRs of 250-1,500 changed lines, Opus 5.5 at high effort, 3 runs per PR per arm, each batch against its own concurrent control. Blind judge (Fable 5) reading source. Paired by PR, 90% bootstrap interval over PRs.
Figures are supported defect families per review.
residual_risklength: about 610 -> 380 characters.Two other single edits were tested and are not included: replacing the "handful of tool calls" sentence (+0.19, interval includes zero) and a pre-submit sweep of unexamined files (+0.16, interval includes zero). Stacked on this edit they added -0.06 and -0.02.
Held-out confirmation on large PRs
8 public PRs of 2,300-3,900 changed lines, not used while choosing the edit. 6 runs per PR per arm, concurrent control, same judge.
residual_riskcharactersChange: +0.65 families (90% interval +0.17 to +1.12); up on 6 PRs, level on 1, down on 1.
Repo evals (ADR-0008)
grouped_cross_file_defect, and it is caused by this prompt: 0 of 8 runs failed on v5, 3 of 9 on v6. The v6 reviewer also reports the removed constant as a breaking change for outside importers, in a group of its own. A trial variant of the prompt with an extra grouping example failed 3 of 12 the same way, once with a fourth finding (a test gap), and was dropped. The grader required any finding on that line to share the callers' group and capped the scenario at 3 findings.Not measured
🤖 Generated with Claude Code