Repository navigation
feat(format): add expanded VALUES row layout - #850
Merged
psteinroe merged 1 commit intoOct 15, 2026
Merged
Conversation
psteinroe
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Formatter feature and bug fix, with configuration, generated bindings, and documentation updates.
What is the current behavior?
VALUESrows stay on one line when they fit withinlineWidth. There is no option to put every tuple on its own indented line. Separators between tuples always use trailing commas, even withcommaStyle: "leading".Related: #816 introduced leading commas for fill lists; this change applies that behavior to
VALUESrows.What is the new behavior?
Add
valuesRowLayout: "expanded"(CLI:--values-row-layout expanded) to put eachVALUEStuple on its own indented line. The default remains"fit".With expanded rows and leading commas:
commaStylebetween tuples in both layouts, using the shared comma-separated list helper.lineWidth.INSERT, standaloneVALUES, subqueries, and CTEs.Additional context
cargo clippy --all-targets --all-features.