Skip to content

style: add missing whitespace - #16522

Merged
kgryte merged 2 commits into
developfrom
claude/trusting-cannon-agektx
Nov 6, 2026
Merged

kgryte merged 2 commits into
developfrom
claude/trusting-cannon-agektx

Conversation

@Planeshifter

@Planeshifter Planeshifter commented Nov 6, 2026 •

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request:

  • propagates fixes merged to develop between 2026-11-05 13:17 UTC and 2026-11-06 13:17 UTC to sibling packages.
  • propagates 7349dff ("style: add missing whitespace"), which restores the closing space in parenthesized argument lists that open with ( but close with ). The same asymmetry exists in user-facing README and TypeScript declaration examples in the following packages:
    • array/typed
    • array/typed-complex
    • array/typed-real
    • number/int32/base/muldw
    • stats/base/dists/gumbel

Related Issues

Does this pull request have any related issues?

No.

Reference Packages

Did the content of this pull request follow one or more existing packages? Answering is optional.

This pull request followed these packages:

  • None. The source change is 7349dff.

What carried over from the reference(s)?

  • The whitespace correction from 7349dff, applied verbatim.

What differed, or what did you have to work out yourself?

  • Locating the remaining sites.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation. The search ran a paren-matching scan over all .js, .ts, .md, and .txt files under lib/node_modules/@stdlib, excluding _tools, data, and fixtures. It found 286 asymmetric sites in 229 files. The scope was then narrowed to user-facing docs (README code blocks, docs/repl.txt, docs/types/index.d.ts, and JSDoc in lib/), which left 14 sites. Two independent validation passes confirmed each remaining site. A style-consistency pass then checked each site against sibling packages. A separate adaptation pass was not needed because the fix is mechanical. Every edit is whitespace outside string literals, so no example output changes.

Deliberately excluded:

  • math/base/special/docs/types/index.d.ts (ns.cosd( 90.0) and ns.sind( 90.0)). This namespace declaration is regenerated from the package declarations, and those were already fixed in 7349dff.
  • docs/repl.txt sites in blas/ext/base/wasm/{dapxsum,dapxsumkbn,dapxsumors,dapxsumpw,sapxsumkbn} and stats/base/dists/weibull/logcdf. The REPL linter checks every file it touches, and these files already fail lint on develop (a redeclared x, and a -0.0 doctest that fix: avoid underflow for small x in stats/base/dists/weibull/logcdf #15797 fixes). They were reverted in 1acd93f so this PR does not take on unrelated fixes.
  • The remaining sites in tests, benchmarks, and scripts (e.g., ndarray/base/*/test/test.*d.js and ndarray/base/fill*/benchmark/*). These are not user-facing, so they are left for a dedicated lint pass.
  • for ( loop headers (e.g., number/int32/base/muldw/README.md:95). These fall outside the call/signature search signature.
  • The other commits in the window (4babd89, d87ead6, and 9b0a318). No sibling sites were found.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written primarily by Claude Code as part of an automated fix-propagation routine.


🤖 Generated with Claude Code

https://claude.ai/code/session_017wWD7AwF3MfT8Zjnw6ezVV

Propagates fix from 7349dff ("style: add missing whitespace") to sibling packages whose README, REPL, and TypeScript declaration examples contain parentheses opened with a space but closed without one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017wWD7AwF3MfT8Zjnw6ezVV
@stdlib-bot

stdlib-bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
array/typed $\\color{red}290/292$
$\\color{green}+99.32\\%$
$\\color{red}17/18$
$\\color{green}+94.44\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{red}290/292$
$\\color{green}+99.32\\%$
array/typed-complex $\\color{green}275/275$
$\\color{green}+100.00\\%$
$\\color{green}13/13$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}275/275$
$\\color{green}+100.00\\%$
array/typed-real $\\color{green}275/275$
$\\color{green}+100.00\\%$
$\\color{green}13/13$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}275/275$
$\\color{green}+100.00\\%$
number/int32/base/muldw $\\color{green}179/179$
$\\color{green}+100.00\\%$
$\\color{green}5/5$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}179/179$
$\\color{green}+100.00\\%$
stats/base/dists/gumbel $\\color{red}2491/2906$
$\\color{green}+85.72\\%$
$\\color{green}37/37$
$\\color{green}+100.00\\%$
$\\color{red}0/35$
$\\color{green}+0.00\\%$
$\\color{red}2491/2906$
$\\color{green}+85.72\\%$

The above coverage report was generated for the changes in this PR.

The REPL help linter flags all files it touches. These files already fail on `develop`: `blas/ext/base/wasm/*apxsum*` redeclares `x` in the `ndarray` example, and the `weibull/logcdf` doctest expects `-0.0`. Fixing either falls outside the scope of this propagation. The `weibull/logcdf` doctest fix is already in #15797.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017wWD7AwF3MfT8Zjnw6ezVV
@kgryte
kgryte marked this pull request as ready for review November 6, 2026 21:59
@kgryte
kgryte requested a review from a team November 6, 2026 21:59
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Nov 6, 2026
@kgryte kgryte changed the title style: add missing whitespace in documentation examples style: add missing whitespace Nov 6, 2026
@kgryte
kgryte merged commit 8f624de into develop Nov 6, 2026
35 checks passed
@kgryte
kgryte deleted the claude/trusting-cannon-agektx branch November 6, 2026 22:00
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants