Repository navigation
Conversation
GET /api/version/check is registered at the Configure tier, so reading it through the app's passthrough asked for a passkey ceremony. The iPhone app is about to show the running version, a newer one and its notes in Settings, and Face ID is the wrong cost for a question. Mark the GET NoStepUp. It stays Configure, so an owner is still required and a viewer cannot make the box ask GitHub with ?force=1. Installing (POST /api/version/update) and every other version write keep the ceremony. Tests cover the route table and the passthrough: the owner's read reaches the handler, the update still answers E_NEEDS_STEP_UP and a viewer is refused. The passthrough section of docs/protocol.md now names the routes that skip the ceremony. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A tester (xorath, 16 Nov 2026) asked to update the box from the phone, and Fredrik agreed it should be one button. The box's own page has had Update FTW since October; neither app has it.
GET /api/version/checkis registered at the Configure tier with a ceremony. Through the app's passthrough, the phone getsE_NEEDS_STEP_UPjust for asking whether a newer Core exists. It would need Face ID every time Settings opens.Change
GET /api/version/checkis markedNoStepUp. It stays Configure, so an owner is still required, and a viewer cannot make the box ask GitHub with?force=1.POST /api/version/updateand the other version writes keep the ceremony.docs/protocol.mdnow names the routes that skip the ceremony. It said only "the charging schedule today", but FTW Cloud's grant and statistics already skipped it as well.Docker and Home Assistant are unchanged.
Deps.SelfUpdateis nil there, so every/api/version/*still answers 503self-update disabled. Only a native install started byftw-launcher(which setsFTW_NATIVE_SLOT_ROOT) updates itself. The app shows the button only on a native box.Evidence
TestVersionCheckSkipsTheCeremonyButTheUpdateDoesNot: the route table marks the check (with and without?force=1) Configure and NoStepUp. The six version writes stay Configure with the ceremony, and the status route stays Read.TestAnOwnerReadsTheVersionCheckWithoutACeremony: the owner's read reaches the handler, which answers 503 on a box without a native updater.TestTheUpdateStillNeedsTheCeremony: the update still answersE_NEEDS_STEP_UP.TestAViewerCannotReadTheVersionCheck: a viewer getsE_SCOPE_DENIED.make verifypasses locally.Paired PR
The iPhone app's Version row and Update FTW button are in srcfl/ftw-app#198. On a box without this change, the app asks for Face ID before it reads the check, so today's boxes can still update from the phone.
Still owed: the web client's working copy of the protocol,
ftw-webapp/docs/protocol.md, has the same "the charging schedule today" sentence. It should change when the web client gets its own Version row.Not merged. Fredrik decides.
🤖 Generated with Claude Code