Repository navigation
Fix two columns on the iPhone Duo unfolded in landscape - #919
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The focused stylesheet changes consistently match the upstream fix and the described behavior.
0 open findings
What changed in this PR
Ports Readium CSS’s responsive-column fix to bundled EPUB stylesheets.
Changes:
- Enables automatic two-column layouts on wide landscape viewports.
- Applies forced column counts at all viewport sizes.
- Documents the fix in the changelog.
| File | Description |
|---|---|
CHANGELOG.md |
Records the Duo layout fix. |
readium-css/ReadiumCSS-after.css |
Updates default horizontal pagination rules. |
readium-css/rtl/ReadiumCSS-after.css |
Updates RTL pagination rules. |
readium-css/cjk-horizontal/ReadiumCSS-after.css |
Updates horizontal CJK pagination rules. |
Files not reviewed (3)
- Sources/Navigator/EPUB/Assets/Static/readium-css/ReadiumCSS-after.css: Generated file
- Sources/Navigator/EPUB/Assets/Static/readium-css/cjk-horizontal/ReadiumCSS-after.css: Generated file
- Sources/Navigator/EPUB/Assets/Static/readium-css/rtl/ReadiumCSS-after.css: Generated file
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Oct 9, 2026
Member
Author
|
This is now released as 3.11.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes reflowable EPUBs being displayed as a single column on the iPhone Duo unfolded in landscape.
☝️ The hotfix/3.11.1 branch contains the same fix, but for the latest stable 3.11.0 release. It might get released officially, not sure yet.
This ports the responsive columns fix from the Readium CSS
v1-maintenancebranch (readium/css#247, future 1.1.2) to the bundled stylesheets. Only the two relevant upstream hunks are applied. The bundled Readium CSS stays based on 1.0.0-beta.1 to prevent regressions.Supersedes #903, thanks to @jeremygrenier for the report and the initial fix.
Behavior changes
columnCountset toauto.EPUBPreferences.columnCount(.oneor.two) now applies to any viewport size. Previously, it was ignored on small viewports such as an iPhone in portrait.horizontal-viewport-segments: 2query has no effect yet, becauseWKWebViewdoes not expose viewport segments on iOS 27.1.