Repository navigation
Replace deprecated maven-verifier with custom RunningMavenProcess - #793
Merged
tsegismont merged 1 commit intoOct 19, 2026
Merged
Conversation
`org.apache.maven.shared:maven-verifier` is deprecated and scheduled for removal. This commit migrates all integration tests off it. A new `RunningMavenProcess` helper class replaces both `Verifier` (for static-outcome tests) and `RunningVerifier` (for long-running process tests). It uses `ProcessBuilder` directly, supports blocking (`execute()`) and non-blocking (`start()`/`stop()`) modes, captures stdout and stderr via background reader threads, and forwards `maven.home` and `maven.repo.local` from system properties. On Windows, `stop()` uses `WinProcess.killRecursively()` to terminate the entire process tree; on Linux it sends SIGTERM and falls back to SIGKILL after a grace period. Tests that had direct equivalents in the existing Maven Invoker test suite are removed from the Java IT layer: - `SetupIT` is deleted; two new invoker projects cover the verticle-creation scenarios - `PackagingIT.testAlternativeOutputDir` and `testContentInTheJar` are dropped (the latter already covered by `package-archive-dependencies-it`) - `RunIT.testResourceOrdering` and `testRunAppUsingVertxSnapshotVersion` become invoker projects Assisted-By: Claude Sonnet 4.6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
org.apache.maven.shared:maven-verifieris deprecated and scheduled for removal. This commit migrates all integration tests off it.A new
RunningMavenProcesshelper class replaces bothVerifier(for static-outcome tests) andRunningVerifier(for long-running process tests). It usesProcessBuilderdirectly, supports blocking (execute()) and non-blocking (start()/stop()) modes, captures stdout and stderr via background reader threads, and forwardsmaven.homeandmaven.repo.localfrom system properties. On Windows,stop()usesWinProcess.killRecursively()to terminate the entire process tree; on Linux it sends SIGTERM and falls back to SIGKILL after a grace period.Tests that had direct equivalents in the existing Maven Invoker test suite are removed from the Java IT layer:
SetupITis deleted; two new invoker projects cover the verticle-creation scenariosPackagingIT.testAlternativeOutputDirandtestContentInTheJarare dropped (the latter already covered bypackage-archive-dependencies-it)RunIT.testResourceOrderingandtestRunAppUsingVertxSnapshotVersionbecome invoker projectsAssisted-By: Claude Sonnet 4.6