Skip to content

test(e2e): run every RL e2e with the output store on, generated output included (CI only, do not merge) - #377

Open
Rockdu wants to merge 6 commits into
mainfrom
rockdu/output-store-generated-output-ci
Open

Rockdu wants to merge 6 commits into
mainfrom
rockdu/output-store-generated-output-ci

Conversation

@Rockdu

@Rockdu Rockdu commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

CI only, do not merge. #382's commits plus two commits that put every RL e2e test on the output store and keep a suite running after a failed test. GitHub would not retarget this PR's base to #382's branch, so the base stays main and the diff here also shows #382.

What

Why

#382 makes the reward actors read the decoded output from the store. The e2e standards were recorded inline and are compared strictly, so a green run with the store on in every RL test checks #382 end to end on GPU, with real Mooncake.

  • The six PickScore tests gate the PickScore actor reading a stored output; in H3, LTX-2.3 and Wan2.2 it picks its frames of a whole stored video.
  • The two OCR tests gate an image reward actor reading a stored output, which no store-on test on main covers.
  • All eight run at feat(rollout): let reward actors read the generated output from the output store #382's new defaults: a 72gb segment and the rdma transport, with reward actors reading through a registered buffer. A red run at Mooncake setup means the CI hosts cannot use RDMA from these containers.

The krea2 test also covers rollouts fetched by the rollout manager, and SD3.5 OCR covers rollouts fetched in the parser actors.

SGLang

The CI default, sglang-miles head, already contains sgl-project/sglang#49877, which stores the output, so no ci-sglang-pr pin is needed.

@Rockdu Rockdu added the run-ci-e2e Run e2e metric-regression tests on this PR label Nov 11, 2026
@Rockdu
Rockdu added this pull request to stack #378 November 11, 2026 15:50
@Rockdu
Rockdu marked this pull request as ready for review November 11, 2026 15:50
@Rockdu
Rockdu force-pushed the rockdu/output-store-generated-output branch from 9a97039 to 5b83312 Compare November 11, 2026 19:55
@Rockdu
Rockdu force-pushed the rockdu/output-store-generated-output-ci branch from a76005d to 1147df8 Compare November 11, 2026 19:55
Base automatically changed from rockdu/output-store-generated-output to main November 11, 2026 19:58
@Rockdu
Rockdu force-pushed the rockdu/output-store-generated-output-ci branch 4 times, most recently from e734a95 to 4228523 Compare November 12, 2026 00:32
@Rockdu
Rockdu force-pushed the rockdu/output-store-generated-output-ci branch 2 times, most recently from 6758deb to db69eab Compare November 12, 2026 04:16
@Rockdu
Rockdu force-pushed the rockdu/output-store-generated-output-ci branch from db69eab to 51d635d Compare November 12, 2026 06:29
@Rockdu
Rockdu removed this pull request from stack #378 November 12, 2026 06:37
…oCE bond, so Mooncake's rdma transport can connect

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-ci-e2e Run e2e metric-regression tests on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant