Repository navigation
Conversation
Rockdu
marked this pull request as ready for review
November 11, 2026 15:50
Rockdu
force-pushed
the
rockdu/output-store-generated-output
branch
from
November 11, 2026 19:55
9a97039 to
5b83312
Compare
Rockdu
force-pushed
the
rockdu/output-store-generated-output-ci
branch
from
November 11, 2026 19:55
a76005d to
1147df8
Compare
Base automatically changed from
rockdu/output-store-generated-output
to
main
November 11, 2026 19:58
Rockdu
force-pushed
the
rockdu/output-store-generated-output-ci
branch
4 times, most recently
from
November 12, 2026 00:32
e734a95 to
4228523
Compare
5 tasks done
Rockdu
force-pushed
the
rockdu/output-store-generated-output-ci
branch
2 times, most recently
from
November 12, 2026 04:16
6758deb to
db69eab
Compare
…utput store so the rollout process never reads it
…llout's outputs can wait there for their reward
… are far faster than tcp
Rockdu
force-pushed
the
rockdu/output-store-generated-output-ci
branch
from
November 12, 2026 06:29
db69eab to
51d635d
Compare
…oCE bond, so Mooncake's rdma transport can connect
3 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI only, do not merge. #382's commits plus two commits that put every RL e2e test on the output store and keep a suite running after a failed test. GitHub would not retarget this PR's base to #382's branch, so the base stays
mainand the diff here also shows #382.What
test(e2e): run the two inline RL e2e tests with the output store on too--use-output-store --output-store-mooncake-master 127.0.0.1:<port>to the two tests test(e2e): run the RL e2e tests with the output store on, keep two inline gates #373 kept inline: SD3.5 OCR GRPO (port 50067) and krea2 NFT async (port 50063).ci: keep running a suite after a failed test on this PR--continue-on-errortorun_suite.py, as nightly does, so one red e2e test does not hide the rest.Why
#382 makes the reward actors read the decoded output from the store. The e2e standards were recorded inline and are compared strictly, so a green run with the store on in every RL test checks #382 end to end on GPU, with real Mooncake.
72gbsegment and therdmatransport, with reward actors reading through a registered buffer. A red run at Mooncake setup means the CI hosts cannot use RDMA from these containers.The krea2 test also covers rollouts fetched by the rollout manager, and SD3.5 OCR covers rollouts fetched in the parser actors.
SGLang
The CI default, sglang-miles head, already contains sgl-project/sglang#49877, which stores the output, so no
ci-sglang-prpin is needed.