Repository navigation
build(deps): bump google-cloud-gax from 0.19.2 to 1.15.0 in /quickwit in the google-cloud group across 1 directory - #6940
Conversation
dependabot
Bot
added
dependencies
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8683c61d41
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| # of google-cloud-pubsub is "0.30" which explicitly depends on: google-cloud-auth ^0.17 and google-cloud-gax ^0.19. | ||
| google-cloud-auth = { version = "0.17", default-features = false, features = ["rustls-tls"] } | ||
| google-cloud-gax = "0.19" | ||
| google-cloud-gax = "1.15" |
There was a problem hiding this comment.
When the gcp-pubsub feature is enabled, the lockfile now resolves Quickwit's direct google-cloud-gax dependency to 1.15.0 while google-cloud-pubsub 0.30.0 still uses GAX 0.19.2. gcp_pubsub_source.rs imports RetrySetting from the direct dependency and passes it to Subscription::exists, whose parameter belongs to Pub/Sub's distinct GAX 0.19 type, so the GCP/all-features build cannot compile. Retain GAX 0.19 or upgrade the Pub/Sub dependency and its API usage together.
AGENTS.md reference: AGENTS.md:L142-L143
Useful? React with 👍 / 👎.
| name = "google-cloud-rpc" | ||
| version = "1.6.0" |
There was a problem hiding this comment.
Adding GAX 1.15 also introduces the new google-cloud-rpc and google-cloud-wkt packages, but LICENSE-3rdparty.csv was not regenerated: it contains neither new package and still describes google-cloud-gax as the unrelated MIT-licensed yoshidan crate. The thirdparty-license CI job runs dd-rust-license-tool ... check, so this stale inventory will fail that required check and would publish incorrect dependency attribution if bypassed.
AGENTS.md reference: AGENTS.md:L104-L107
Useful? React with 👍 / 👎.
dependabot
Bot
changed the title
8683c61 to
e37ec10
Compare
Bumps the google-cloud group with 1 update in the /quickwit directory: [google-cloud-gax](https://github.com/googleapis/google-cloud-rust). Updates `google-cloud-gax` from 0.19.2 to 1.15.0 - [Release notes](https://github.com/googleapis/google-cloud-rust/releases) - [Commits](https://github.com/googleapis/google-cloud-rust/commits) --- updated-dependencies: - dependency-name: google-cloud-gax dependency-version: 1.15.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: google-cloud ... Signed-off-by: dependabot[bot] <support@github.com>
e37ec10 to
94a3d08
Compare
Bumps the google-cloud group with 1 update in the /quickwit directory: google-cloud-gax.
Updates
google-cloud-gaxfrom 0.19.2 to 1.15.0Release notes
Sourced from google-cloud-gax's releases.
Commits