Repository navigation
Fix narrowing after always-true blocks with allow-redefinition - #22276
Closed
zhengguangzhuo wants to merge 1 commit into
Closed
zhengguangzhuo wants to merge 1 commit into
zhengguangzhuo wants to merge 1 commit into
Conversation
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: pwndbg (https://github.com/pwndbg/pwndbg)
- pwndbg/commands/__init__.py:935: error: Unused "type: ignore" comment [unused-ignore]
- pwndbg/commands/__init__.py: note: In function "OnlyWhenRunning":
- pwndbg/commands/__init__.py:935: error: Item "function" of "Callable[P, T] | None" has no attribute "_pwndbg_only_when_running_allow_core" [union-attr]
- pwndbg/commands/__init__.py:935: note: Error code "union-attr" not covered by "type: ignore[attr-defined]" comment
scipy-stubs (https://github.com/scipy/scipy-stubs)
- tests/misc/test_submodules_empty.pyi:3: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22259.
When --allow-redefinition is enabled, narrowing performed inside a statically always-true if True or if TYPE_CHECKING block is lost after the block. The merge logic treated semantically equivalent types as identical and kept the less-narrowed representation, while the unreachable else path could still contribute the pre-if state.
This change preserves the narrowed representation in the new semantics and excludes the unreachable path from the merge. Regression tests cover if True with and without --allow-redefinition, and TYPE_CHECKING with the option enabled.
Verification:
This contribution was prepared with assistance from OpenAI Codex.