Repository navigation
Conversation
For `obj.attr += x`, look up and check the in-place method on the type read from the attribute (the property getter or descriptor __get__ result), and check the result against the type written to it (the setter or __set__ value type). Previously the setter type was used for both, which caused false positives and false negatives when the two types differ. Fixes python#22273
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
obj.attr += x, look up and check the in-place method on the type read from the attribute (the property getter or descriptor__get__result), and check the result against the type written to it (the setter or__set__value type). Previously the setter type was used for both, which caused false positives and false negatives when the two types differ.Fixes #22273