Repository navigation
fix(cmake): correct AUTHOR_WARNING calls and the VIRTUAL_ENV check - #6240
Open
kroplabeskidu wants to merge 2 commits into
Open
kroplabeskidu wants to merge 2 commits into
kroplabeskidu wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Items 52 and 53 from #6159.
message(AUTHOR_WARNING, ...): the comma makes the first argumentAUTHOR_WARNING,, which isn't a message mode, so the text was printed as a plain message starting withAUTHOR_WARNING,. Fixed at both call sites..venvautodetection checkedENV{VIRTUALENV}, but the variable isVIRTUAL_ENV, so a.venvin the source tree was used even with another venv active. WithVIRTUAL_ENVset, configuring no longer printsAutodetecting Python in virtual environment.I checked both by hand with CMake. There are no new tests.
Suggested changelog entry:
SETUPTOOLS_EXT_SUFFIXmismatch warning so it is issued as an author warning, and made.venvautodetection respect an activeVIRTUAL_ENV.