Repository navigation
fix: copy every item of a zero-stride buffer in bind_vector - #6236
Open
kroplabeskidu wants to merge 1 commit into
Open
kroplabeskidu wants to merge 1 commit into
kroplabeskidu wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Item 14 from #6159. The buffer constructor from
py::bind_vectorcomputesend = p + shape * stepand loops untilp == end. With a stride of 0, as innp.broadcast_to,end == p, so the result is an empty vector with no error:The loop now counts items instead of comparing pointers. I also added a test for negative strides, which already worked and had no test.
Suggested changelog entry:
py::bind_vector's buffer constructor now copies every item from zero-stride buffers instead of returning an empty vector.