Repository navigation
fix: render titles in basic POWL diagrams - #575
Open
ryanduguid wants to merge 1 commit into
Open
ryanduguid wants to merge 1 commit into
ryanduguid wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The basic POWL renderer reads the graph-title parameters but never adds a label, so
save_vis_powl(..., graph_title="Review")silently drops the title. Render enabled titles above the graph, using the same font size as the Petri-net variant, and escape the title as text.Evidence
visualization_facade_deep_coverage_test,powl_discovery_coverage_testandpowl_tree_generation_deep_coverage_testpass. The SVG checks cover disabled titles, both parameter-key forms, the configured default and literal<,&and quotes.F,E9) andgit diff --checkpass. The renderer's twoF841findings are resolved.Risk
Enabled graph titles now occupy space above basic POWL diagrams; disabled titles keep the existing output.
Unverified
The full project suite, hosted CI, package builds and rendering on other platforms were not run. Rendering was tested on Linux with Python 3.11.17 and Graphviz 16.1.0.