Repository navigation
Add the Plone icon to @plone/icons - #410
Open
NopeCharon wants to merge 1 commit into
Open
NopeCharon wants to merge 1 commit into
NopeCharon wants to merge 1 commit into
Conversation
The icon gallery had a VoltoIcon but no icon for Plone itself. Add the Plone logo mark as a raw SVG (src/svg/plone.svg) and as a React component (PloneIcon), exported from src/icons/index.ts so it also shows up in the Storybook gallery. The paths come from the Volto icon set, where the mark is drawn on a 36x36 canvas with a 4px margin. The viewBox is cropped to "3 3 31 31" (centered on the circle) so the mark fills the 24x24 box like the other Quanta icons instead of rendering small. No fill is set, so the icon inherits currentColor like the rest of the set. Closes plone#407 Signed-off-by: NopeCharon <115794254+NopeCharon@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the Plone logo mark to
@plone/icons, next to the existingVoltoIcon:src/svg/plone.svg, the raw SVG.src/icons/PloneIcon.tsx, the React component, exported fromsrc/icons/index.ts. The Storybook gallery lists every export ofsrc/icons, so it shows up there without further changes.featurenews fragment.The paths come from Volto's
plone.svg. That file draws the mark on a 36×36 canvas with a margin, so theviewBoxis cropped to3 3 31 31(centered on the circle) to make the mark fill the 24×24 box like the other icons. Nofillis set, so it followscurrentColor.I did not add a unit test: the package doesn't test individual icons, and the gallery renders every export. CI runs the package checks.
I didn't add an Aurora logo icon, since the issue only asked about it as a question.
Closes #407