Repository navigation
feat: copy files back only when a check reads them - #348
Closed
AydinHassan wants to merge 2 commits into
Closed
AydinHassan wants to merge 2 commits into
AydinHassan wants to merge 2 commits into
Conversation
AydinHassan
force-pushed
the
one-container
branch
from
November 1, 2026 17:29
6e55385 to
d7cc2c3
Compare
Member
Author
|
Replaced by #349 |
AydinHassan
added a commit
that referenced
this pull request
Nov 1, 2026
For #336, before #346. Replaces #348. Once the code runs in a container with the files copied in, the files it writes have to come back for the checks that read them. This says which files those are. No behaviour change yet. - New `Check\ReadsSolutionFiles` interface: `getSolutionFiles(ExerciseInterface): list<string>`. `DatabaseCheck` returns `['db.sqlite']`, `FileComparisonCheck` the exercise's files to compare. - `ExerciseDispatcher::verify()` collects them from the required checks into `ExecutionContext::getSolutionFiles()`. - `Sandbox::finish(ExecutionContext $context)`. `HostSandbox` and today's mounted `DockerSandbox` have the files already, so they ignore it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #346.
Check\ReadsSolutionFilesmarker interface, onDatabaseCheckandFileComparisonCheck.ExerciseDispatchersetsExecutionContext::readsSolutionFiles()when a required check has it; verify passes it toSandbox::finish($copyFilesBack).runnever copies back.