Repository navigation
fix: silence the warnings cargo check --all-targets reports - #2369
Open
zac-scheiwe wants to merge 1 commit into
Open
zac-scheiwe wants to merge 1 commit into
zac-scheiwe wants to merge 1 commit into
Conversation
- hax-adt-into: declare the `rustc` feature cfg that `AdtInto` emits, and make the test's `mirrored` module public so its example type is not reported as dead code. - hax-rust-engine: mark the `hax-lib` dev-dependency as used in test builds; it is only there for documentation links.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo check --all-targetscurrently reports three warnings. This PR fixes them; there is no behaviour change.hax-adt-into:AdtIntoemits#[cfg(feature = "rustc")]into the crate that derives it. This crate's own test derives it, buthax-adt-intohas norustcfeature, sounexpected_cfgsfires. Declare the value withcheck-cfgunder[lints.rust].hax-adt-intotests: make themirroredmodulepubso its example type isn't reported as dead code.hax-rust-engine: the crate enablesunused_crate_dependencies, andhax-libis a dev-dependency used only for doc links. Mark it used in test builds with#[cfg(test)] use hax_lib as _;.[skip changelog]