Skip to content

add code for s3 docs - #4

Merged
mdmalhou merged 3 commits into
mainfrom
moha/s3
Jul 20, 2023
Merged

mdmalhou merged 3 commits into
mainfrom
moha/s3

Conversation

@mdmalhou

Copy link
Copy Markdown
Contributor

No description provided.

@mdmalhou
mdmalhou requested a review from KamilPiechowiak July 19, 2023 14:50

@KamilPiechowiak KamilPiechowiak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the doc with an example not only how to run it but also how to call it.
The code works and looks good. Left one minor suggestion.

Comment thread llm_app/pathway_pipelines/contextful_s3/app.py Outdated
Co-authored-by: Kamil Piechowiak <32928185+KamilPiechowiak@users.noreply.github.com>
@mdmalhou
mdmalhou merged commit 030d459 into main Jul 20, 2023
@mdmalhou
mdmalhou deleted the moha/s3 branch July 20, 2023 08:47
Pathway-Dev added a commit that referenced this pull request Aug 18, 2023
* first commit

ORIGINAL_AUTHOR=mdmalhou <mohamed@pathway.com>
GitOrigin-RevId: e26f857

* remove unused files

ORIGINAL_AUTHOR=mdmalhou <mohamed@pathway.com>
GitOrigin-RevId: 175575f

* Merge pull request #1 from pathwaycom/moha/cache

use cache

ORIGINAL_AUTHOR=Mohamed Malhou <123164531+mdmalhou@users.noreply.github.com>
GitOrigin-RevId: aeac612

* add formatting (#2)

* add formatting

* add default vscode settings

* configure isort, black, flake8

* remove absolute paths

* remove ColumnExpressionOrConst

ORIGINAL_AUTHOR=Kamil Piechowiak <32928185+KamilPiechowiak@users.noreply.github.com>
GitOrigin-RevId: 5995bb8

* remove debug and provide smaller dataset for local processing (#3)

ORIGINAL_AUTHOR=Kamil Piechowiak <32928185+KamilPiechowiak@users.noreply.github.com>
GitOrigin-RevId: 8e64918

* Updates to README and FEATURES-for-organizations (#6)

ORIGINAL_AUTHOR=Adrian Kosowski <adrian@pathway.com>
GitOrigin-RevId: 9b42436

* Fix repo paths in README.md

ORIGINAL_AUTHOR=Adrian Kosowski <adrian@pathway.com>
GitOrigin-RevId: aeb4143

* add code for s3 docs (#4)

* add code for s3 docs

* Update llm_app/pathway_pipelines/contextful_s3/app.py

Co-authored-by: Kamil Piechowiak <32928185+KamilPiechowiak@users.noreply.github.com>

---------

Co-authored-by: Kamil Piechowiak <32928185+KamilPiechowiak@users.noreply.github.com>
ORIGINAL_AUTHOR=Mohamed Malhou <123164531+mdmalhou@users.noreply.github.com>
GitOrigin-RevId: 030d459

* add docstrings to hf (#5)

* add docstrings to hf

* apply suggestions

* add link to hf

ORIGINAL_AUTHOR=Mohamed Malhou <123164531+mdmalhou@users.noreply.github.com>
GitOrigin-RevId: cb1bf1a

* Add details to README (#8)

* explained steps

* apply suggestion

ORIGINAL_AUTHOR=Mohamed Malhou <123164531+mdmalhou@users.noreply.github.com>
GitOrigin-RevId: 5192fbf

* dockerize app (#9)

* add boilerplate

* fix path

* use python3.11 image

* Apply suggestions from code review

Co-authored-by: Mateusz Lewandowski <lewymati@users.noreply.github.com>

* use docker and env for mode

* add volume

* add volume to docker

* Update README.md

---------

Co-authored-by: Mateusz Lewandowski <lewymati@users.noreply.github.com>
Co-authored-by: Kamil Piechowiak <32928185+KamilPiechowiak@users.noreply.github.com>
ORIGINAL_AUTHOR=Mohamed Malhou <mohamed@pathway.com>
GitOrigin-RevId: 2c50e6c

* add data volume to docker-compose (#10)

* add data volume to docker-compose

* Update README.md

ORIGINAL_AUTHOR=Kamil Piechowiak <32928185+KamilPiechowiak@users.noreply.github.com>
GitOrigin-RevId: 8260ac1

* Update README.md: remove broken badge (#11)

ORIGINAL_AUTHOR=Adrian Kosowski <adrian@pathway.com>
GitOrigin-RevId: 5cce64d

* README: added blog entry (#12)

ORIGINAL_AUTHOR=Adrian Kosowski <adrian@pathway.com>
GitOrigin-RevId: e519693

* remove volumes and use dc cp (#13)

* remove volumes and use dc cp

* use pathway pypi

ORIGINAL_AUTHOR=Mohamed Malhou <mohamed@pathway.com>
GitOrigin-RevId: 7039a84

* Video link in README.md, architecture image in features (#16)

ORIGINAL_AUTHOR=Adrian Kosowski <adrian@pathway.com>
GitOrigin-RevId: 4411ef9

* change gpt-4 to gpt-3.5 (#19)

ORIGINAL_AUTHOR=Mohamed Malhou <mohamed@pathway.com>
GitOrigin-RevId: 042c51e

* remove jq from README.md (#20)

ORIGINAL_AUTHOR=Kamil Piechowiak <32928185+KamilPiechowiak@users.noreply.github.com>
GitOrigin-RevId: f087f0a

* Moha/optional reqs (#21)

* separate requirements

* update readme

* remove jq

ORIGINAL_AUTHOR=Mohamed Malhou <mohamed@pathway.com>
GitOrigin-RevId: 552aaef

* add section coming soon (#22)

* add section coming soon

* Update README.md

Co-authored-by: Kamil Piechowiak <32928185+KamilPiechowiak@users.noreply.github.com>

* remove line from coming soon

---------

Co-authored-by: Kamil Piechowiak <32928185+KamilPiechowiak@users.noreply.github.com>
ORIGINAL_AUTHOR=Mohamed Malhou <mohamed@pathway.com>
GitOrigin-RevId: 1167b40

* Add improvement changes (#23)

* Add improvement changes

* Remove the

* Fix spaces

* Add selling messages

* Make quick links smaller

* Update top banner text

* Fix table

* Example should come after

---------

Co-authored-by: boburumurzokov <borbur.umurzokov@astrazeneca.com>
ORIGINAL_AUTHOR=Bobur Umurzokov <boburmirzo.umurzokov@gmail.com>
GitOrigin-RevId: 842f781

* README: video thumbnail image (#24)

ORIGINAL_AUTHOR=Adrian Kosowski <adrian@pathway.com>
GitOrigin-RevId: 7724436

* add banner (#26)

Co-authored-by: boburumurzokov <borbur.umurzokov@astrazeneca.com>
ORIGINAL_AUTHOR=Bobur Umurzokov <boburmirzo.umurzokov@gmail.com>
GitOrigin-RevId: c98f9a6

* add thumbnail to assets (#27)

ORIGINAL_AUTHOR=Mohamed Malhou <mohamed@pathway.com>
GitOrigin-RevId: ea6df43

* add Use Cases section to README  (#28)

ORIGINAL_AUTHOR=Mohamed Malhou <mohamed@pathway.com>
GitOrigin-RevId: 602f8b6

* removing typo in Use Cases (#29)

ORIGINAL_AUTHOR=Adrian Kosowski <adrian@pathway.com>
GitOrigin-RevId: c88e7db

* Readme clarifications (#30)

ORIGINAL_AUTHOR=Adrian Kosowski <adrian@pathway.com>
GitOrigin-RevId: 08dd801

* README: bash script display fix (#31)

* README: bash script display fix

* remove indent

---------

Co-authored-by: mdmalhou <mohamed@pathway.com>
ORIGINAL_AUTHOR=Adrian Kosowski <adrian@pathway.com>
GitOrigin-RevId: be6bf8f

* Make it clearer that we provide several runnable examples. (#33)

* Make it clearer that we provide several runnable examples.

* Simplify steps

* Update README.md

Co-authored-by: Adrian Kosowski <adrian@pathway.com>

---------

Co-authored-by: Adrian Kosowski <adrian@pathway.com>
ORIGINAL_AUTHOR=Jan Chorowski <janchorowski@users.noreply.github.com>
GitOrigin-RevId: 3513cef

* Use sentence-transformers in local mode. (#35)

* Use sentence-transformer

* Update requirements/hf-local.txt

ORIGINAL_AUTHOR=Jakub Kowalski <kuba@pathway.com>
GitOrigin-RevId: 57f8081

* make it pypi project with poetry (#34)

* add poetry

* add config and click options

* Apply suggestions from code review

Co-authored-by: Micha艂 Bartoszkiewicz <embe@pathway.com>

* apply review suggestions

* fix build, add authors

* __main__

* Fix merge

* LIbrary packaging (#36)

* Move to examples

* Move docker files

* Remove requirements

* Idependent examples

* Separate cli.commands

* WIP

* Cleanup

* Extra deps

* Docker

* Some docs

* README

* README

* Update README.md

* Typo

* Unnecessary .gitignore

* Better cli descriptions

* Fix contextless

* Add local run instructions and fix readme

---------

Co-authored-by: Micha艂 Bartoszkiewicz <embe@pathway.com>
Co-authored-by: Jakub Kowalski <kuba@pathway.com>
Co-authored-by: Jan Chorowski <jan.chorowski@pathway.com>
ORIGINAL_AUTHOR=Mohamed Malhou <mohamed@pathway.com>
GitOrigin-RevId: 0f6ad0d

* Bump version.

ORIGINAL_AUTHOR=Jan Chorowski <janchorowski@users.noreply.github.com>
GitOrigin-RevId: 72f0b08

* Fix poetry flags (#38)

ORIGINAL_AUTHOR=Jakub Kowalski <kuba@pathway.com>
GitOrigin-RevId: 25e2a10

* README: images on CDN  (#39)

ORIGINAL_AUTHOR=Pawel Podhajski <106311100+pw-ppodhajski@users.noreply.github.com>
GitOrigin-RevId: 7d5ba47

* Lint fix issues (#47)

* add mypy config file

* fix issues

* fixes from review

ORIGINAL_AUTHOR=Pawel Podhajski <106311100+pw-ppodhajski@users.noreply.github.com>
GitOrigin-RevId: 7b79efa

* Rephrased README introduction

* Update Readme file, rephrase the intro

* Seperate sentences

ORIGINAL_AUTHOR=Bobur Umurzokov <boburmirzo.umurzokov@gmail.com>
GitOrigin-RevId: 2c1ae30

* Readme: Move table into getting started

Move table into Get started

Minor language fixes

Co-authored-by: Adrian Kosowski <adrian@pathway.com>
ORIGINAL_AUTHOR=Bobur Umurzokov <boburmirzo.umurzokov@gmail.com>
GitOrigin-RevId: 1bc32d1

* Add Github Actions linters workflow  (#48)

ORIGINAL_AUTHOR=Pawel Podhajski <106311100+pw-ppodhajski@users.noreply.github.com>
GitOrigin-RevId: a613393

* add device argument (#50)

ORIGINAL_AUTHOR=Mohamed Malhou <mohamed@pathway.com>
GitOrigin-RevId: 9e56414

* Add Code of Conduct and Contributing notes. (#55)

* Add Code of Conduct and Contributing notes.

* Update CONTRIBUTING.md

Co-authored-by: Pawel Podhajski <106311100+pw-ppodhajski@users.noreply.github.com>

---------

Co-authored-by: Pawel Podhajski <106311100+pw-ppodhajski@users.noreply.github.com>
ORIGINAL_AUTHOR=Jan Chorowski <janchorowski@users.noreply.github.com>
GitOrigin-RevId: 5edd811

* Fix linters

---------

Co-authored-by: mdmalhou <mohamed@pathway.com>
Co-authored-by: Mohamed Malhou <123164531+mdmalhou@users.noreply.github.com>
Co-authored-by: Kamil Piechowiak <32928185+KamilPiechowiak@users.noreply.github.com>
Co-authored-by: Adrian Kosowski <adrian@pathway.com>
Co-authored-by: Mateusz Lewandowski <lewymati@users.noreply.github.com>
Co-authored-by: Bobur Umurzokov <boburmirzo.umurzokov@gmail.com>
Co-authored-by: boburumurzokov <borbur.umurzokov@astrazeneca.com>
Co-authored-by: Jan Chorowski <janchorowski@users.noreply.github.com>
Co-authored-by: Jakub Kowalski <kuba@pathway.com>
Co-authored-by: Micha艂 Bartoszkiewicz <embe@pathway.com>
Co-authored-by: Jan Chorowski <jan.chorowski@pathway.com>
Co-authored-by: Pawel Podhajski <106311100+pw-ppodhajski@users.noreply.github.com>
GitOrigin-RevId: 8684e52bcbedbb8dd078b5e80b5305f01ec8901e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants