Repository navigation
Document gotchas with sources generated in actions during sync_release - #1180
Open
Nitjsefnie wants to merge 1 commit into
Open
Nitjsefnie wants to merge 1 commit into
Nitjsefnie wants to merge 1 commit into
Conversation
…ncing Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Contributor
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 13s |
Contributor
Author
|
Heads-up: this branch lives in an organization-owned fork, and GitHub doesn't let maintainers push to those. If anything needs changing, just say so here and I'll make the change on this branch right away. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Document the gotcha that actions generating sources during release syncing run once per target dist-git branch: a non-reproducible generator produces a different archive hash on each run, so the archive is uploaded to the lookaside cache again for every branch. The new note recommends making generation reproducible — Packit already checks the lookaside cache by content hash before uploading, so byte-identical archives are not uploaded again.
Related Issues and Pull Requests
Fixes #911
Changes
docs/configuration/examples.md: a note under "Custom archive creation for release syncing" explaining thatpost-upstream-cloneandpre-syncrun once per target branch processed by the release-sync loop, that non-reproducible generation (changing timestamps, randomness) changes the archive hash per run and triggers another lookaside upload per branch, and that reproducible generation lets Packit's existing content-hash lookaside check skip the re-upload.Testing
Docs-only change; nothing was executed locally. Fork CI green on the branch head 57b79c1:
osc-manual.ymlrun 39831010060 on the fork, 1 job green, provenance echo naming that SHA. Upstream CI on this PR: Test deployment green (run 39831664445), zuulpackit-service/checksuccess, pre-commit.ci pass.Footer
Generated by GLM-5.3-Flash (brief, orchestration), GPT-6.1 Sol (research, implementation, review), GPT-6 Astra (review)