Skip to content

refactor(query engine): use only required fields in aggs - #580

Merged
forshev merged 7 commits into
mainfrom
0-agg-datasource
Oct 30, 2026
Merged

forshev merged 7 commits into
mainfrom
0-agg-datasource

Conversation

@forshev

@forshev forshev commented Oct 16, 2026

Copy link
Copy Markdown
Member

Description

  • split datasource into docs datasource and aggs datasource
  • support not_exists in aggs
  • use only required fields in aggs

  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

If you have used LLM/AI assistance please provide model name and full prompt:

Model: {{model-name}}
Prompt: {{prompt}}

@forshev
forshev added this pull request to stack #581 October 16, 2026 15:14
@codecov-commenter

codecov-commenter commented Oct 16, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.02439% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.93%. Comparing base (2d0d610) to head (503200f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
proxyapi/grpc_complex_search.go 0.00% 18 Missing ⚠️
query/exec/agg_datasource.go 87.05% 11 Missing ⚠️
query/exec/agg_expr.go 92.45% 8 Missing ⚠️
query/exec/docs_datasource.go 88.70% 7 Missing ⚠️
query/exec/aggregator.go 98.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #580      +/-   ##
==========================================
+ Coverage   79.78%   79.93%   +0.15%     
==========================================
  Files         259      261       +2     
  Lines       19510    19698     +188     
==========================================
+ Hits        15566    15746     +180     
- Misses       3944     3952       +8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eguguchkin eguguchkin added this to the v0.82.0 milestone Oct 19, 2026
@forshev
forshev force-pushed the 0-agg-datasource branch 2 times, most recently from 8a449b6 to 764a20c Compare October 20, 2026 11:07
Comment thread api/storeapi/store_api.proto Resolved
Base automatically changed from 0-doc-field-extractor to main October 26, 2026 15:03
@github-actions

Copy link
Copy Markdown
Contributor

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
Indexer-4 43040f 1b0577
579150774.00 B/op 756116397.00 B/op 1.31 🔴

Comment thread query/exec/docs_datasource.go Resolved
Comment thread query/exec/agg_expr.go Resolved
@forshev
forshev merged commit 114c797 into main Oct 30, 2026
8 checks passed
@forshev
forshev deleted the 0-agg-datasource branch October 30, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants