Add FindIncompleteAssertions

[Jammy-Louie]

Problem

An assertion that is started but never finished checks nothing, and the test still passes: assertThat(result);, assertThat(result).as("description"); or Mockito.verify(mockedList);. TestsShouldIncludeAssertions counts these as assertions, so these tests look covered.

How

FindIncompleteAssertions marks assertThat(..) (AssertJ, Fest, Truth) and Mockito verify(..) calls whose result isn't used. A chain of only AssertJ configuration calls, like assertThat(x).as("description");, is marked too.

Not covered: AssertJ then(x), soft assertions and BDDMockito then(mock).should().

[timtebeek]

We already have this in https://docs.openrewrite.org/recipes/staticanalysis/findignoredcheckreturnvalue

[timtebeek]

I've used this the other week to find & fix these cases, among others already merged:

• Fix ignored target assertions in ConcurrencyLimitTests spring-projects/spring-framework#37411
• Fix assertions whose result was ignored spring-projects/spring-boot#52045
• Fix AssertJ assertions that never assert spring-projects/spring-security#19836
• test: make vacuous assertThat calls actually assert spinnaker/spinnaker#8143
• Fix test assertions whose results were ignored langchain4j/langchain4j#6625
• Fix AssertJ assertions that never fail spring-projects/spring-ai#7110

[Jammy-Louie]

closing as unnecessary