Repository navigation
Conversation
motlin
force-pushed
the
fix-1110-junit-testsetup-lifecycle
branch
2 times, most recently
from
October 5, 2026 21:53
58b36b9 to
f86fb2e
Compare
motlin
force-pushed
the
fix-1110-junit-testsetup-lifecycle
branch
from
October 17, 2026 20:01
f86fb2e to
dfa791d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
MigrateJUnitTestCasepreserves one-time fixtures from asuite()method returning an anonymousTestSetuparoundnew TestSuite(CurrentTest.class). The decorator'ssetUp()andtearDown()bodies become static@BeforeAlland@AfterAllmethods on the test class.What's your motivation?
TestSetupdecorator performed, breaking tests at run time #1110. Removingsuite()currently discards the setup and teardown performed byTestSetup, leaving tests that compile but fail at runtime because their shared resources were never initialized.