Repository navigation
Treat $/ self-repository references like local actions - #235
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub's workflow dependency lockfiles (public preview) introduce
uses: $/…for same-repository actions and reusable workflows. These refs always resolve to the running commit, so they are inherently pinned and reject a trailing@ref.gh actions-lockalso rewrites existing./…refs to$/…automatically.The security recipes only recognized
./…as local, which led to false positives once a repository adopts the new syntax:UnpinnedActionsflagged$/actions/my-actionas unpinned, since it has no@ref.ForbiddenUsesflagged it as coming from the "single-character organization$".This adds
YamlHelper.isLocalOrDockerUsesand uses it inUnpinnedActions,ForbiddenUses,Obfuscation,RefVersionMismatchandPinGitHubActionsToSha, so all five recipes classify local and Docker refs the same way.Lockfile awareness, such as not flagging or SHA-pinning workflows already onboarded to
actions.lock, is left for a follow-up.