Repository navigation
QP routing - #2381
Open
j-bos wants to merge 2 commits into
Open
QP routing#2381j-bos wants to merge 2 commits into
j-bos wants to merge 2 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Add QP routes keyed by switch, virtual router, QP ID, and destination prefix. Register a separate experimental API and object type using the existing metadata generation paths. Signed-off-by: Jason Bos <jbos@cisco.com>
Signed-off-by: Jason Bos <jbos@cisco.com>
JaiOCP
reviewed
Nov 11, 2026
| [`experimental/saiexperimentalqproute.h`](../experimental/saiexperimentalqproute.h). | ||
|
|
||
| ## 2. Functional Behavior | ||
|
|
Contributor
| * | ||
| * @type sai_object_id_t | ||
| * @flags CREATE_AND_SET | ||
| * @objects SAI_OBJECT_TYPE_NEXT_HOP, SAI_OBJECT_TYPE_NEXT_HOP_GROUP, SAI_OBJECT_TYPE_ROUTER_INTERFACE, SAI_OBJECT_TYPE_PORT |
There was a problem hiding this comment.
given that the goal is to pin to an egress interface, should we avoid accepting SAI_OBJECT_TYPE_NEXT_HOP_GROUP here?
purush-nexthop
suggested changes
Nov 16, 2026
Contributor
|
I don’t think pinnning an egress interface is the goal. Forwarding can resolve via any of the methods.On Nov 15, 2026, at 8:56 PM, purush-nexthop ***@***.***> wrote:
@purush-nexthop commented on this pull request.
In doc/SAI-Proposal-QP-Based-Forwarding.md:
+ * following: FORWARD, COPY, LOG, TRANSIT.
+ *
+ * The next hop id can be a generic next hop object, such as next hop, next
+ * hop group. Directly reachable routes are the IP subnets that are
+ * directly attached to the router. For such routes, fill the router
+ * interface id to which the subnet is attached. IP2ME route adds a local
+ * router IP address. For such routes, fill the CPU port
+ * (#SAI_SWITCH_ATTR_CPU_PORT).
+ * When pointing to a next hop group which is empty, the effective routing
+ * action will be DROP.
+ *
+ * When it is SAI_NULL_OBJECT_ID, then packet will be dropped.
+ *
+ * @type sai_object_id_t
+ * @flags CREATE_AND_SET
+ * @objects SAI_OBJECT_TYPE_NEXT_HOP, SAI_OBJECT_TYPE_NEXT_HOP_GROUP, SAI_OBJECT_TYPE_ROUTER_INTERFACE, SAI_OBJECT_TYPE_PORT
given that the goal is to pin to an egress interface, should we avoid accepting SAI_OBJECT_TYPE_NEXT_HOP_GROUP here?
—Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you commented.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce experimental API to enable routing paths to based on RoCE QP + DIP.
This enables a forwarding decision to be made based on QP + DIP routing entries, with fallback to regular DIP-based forwarding on miss.