Repository navigation
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
rck-innovium
left a comment
There was a problem hiding this comment.
-
Today, the application can attach the sampler/mirror on each member port of the LAG. Please explain the use-case of needing a LAG level sampler/mirror.
-
Please define the expected behavior. For example if a sampler with rate S1 is applied on a LAG with member ports P1 and P2, is the expectation that net sampled packets on both P1 and P2 be around S1 or should each port get around S1?
|
@darius-nexthop - as discussed in the community meeting, please update the PR comments or add documentation to describe behavior when config is applied on both lag and member port. Please also help address comments below |
This is the same model SAI already uses for other per-port features, such as PORT_VLAN_ID or INGRESS_ACL. Sampling is configured on a PortChannel as one interface, which also simplifies work from the application. It also covers platforms that can only sample at the LAG level instead of the port level.
Each member samples 1 in S1 of its own packets. That means the LAG as a whole is also sampled at about 1 in S1. |
@tjchadaga - PR comments have been updated and comments have been addressed, thanks. |
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
@darius-nexthop - could you please squash your commits to a single commit? |
Signed-off-by: Darius Grassi <darius@nexthop.ai>
0acebd5 to
d7424ce
Compare
@tjchadaga I've squashed them, if you can please retrigger the Azure pipeline now. Thanks. |
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Signed-off-by: Darius Grassi <darius@nexthop.ai>
Add SAMPLEPACKET_ENABLE and SAMPLE_MIRROR_SESSION (ingress/egress) to sai_lag_attr_t, mirroring the port attributes. Lets sampling be configured on the LAG instead of on each member port.
The new LAG mirror-session attributes create the same LAG -> MIRROR_SESSION -> MONITOR_PORT loop the port versions have, so they're added to the known-loops skip list in saisanitycheck.