Repository navigation
Fix start timestamps for dynamically created metric instruments - #8992
Open
DevyanshMalhotra wants to merge 1 commit into
Open
DevyanshMalhotra wants to merge 1 commit into
DevyanshMalhotra wants to merge 1 commit into
Conversation
|
|
Pull request dashboard statusWaiting on reviewers · refreshed 2026-10-31 11:53 UTC Review the latest changes. Status above doesn't look right?
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8992 +/- ##
============================================
+ Coverage 90.36% 90.38% +0.01%
Complexity 10995 10995
============================================
Files 1020 1020
Lines 30096 30099 +3
Branches 3929 3929
============================================
+ Hits 27197 27204 +7
+ Misses 1942 1937 -5
- Partials 957 958 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Author
|
Hi maintainers, I checked the failing CI jobs. The macOS Java 8 and Java 11 builds are failing in The remaining platform builds passed, and These appear potentially environment-related. Could someone please rerun the two failed macOS jobs to confirm? Thanks! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8980.
Corrects start timestamps for metric instruments created after a reader has already performed a collection.
Previously, newly created instruments could use the reader's previous collection timestamp even when it was earlier than the instrument's creation time.
The fix uses
Math.maxto select the later of the reader's previous collection timestamp and the instrument creation time.Changes
Validation
./gradlew :sdk:metrics:spotlessApply— passed../gradlew :sdk:metrics:check— passed.