Skip to content

Upgrade to errorprone 2.51.0 - #8989

Merged
jack-berg merged 3 commits into
open-telemetry:mainfrom
jack-berg:update-error-prone
Oct 30, 2026
Merged

jack-berg merged 3 commits into
open-telemetry:mainfrom
jack-berg:update-error-prone

Conversation

@jack-berg

Copy link
Copy Markdown
Member

Peeled errorprone update away from #8977 because it has new checks that require some code changes.

@jack-berg
jack-berg requested a review from a team as a code owner October 29, 2026 18:16
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Pull request dashboard status

Merged · refreshed 2026-10-30 13:52 UTC

Status above doesn't look right?
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

excludedPaths.set(".*/build/generated/.*|.*/internal/shaded/.*")

// Still Java 8
disable("TraditionalJavadocToMarkdown")

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a preference to use java 25+ markdown javadoc, which we can't do bc java 8 language level

@codecov

codecov Bot commented Oct 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.38%. Comparing base (acb1599) to head (97adf82).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...orter/otlp/internal/OtlpDeclarativeConfigUtil.java 50.00% 1 Missing and 1 partial ⚠️
...edchannel/internal/UpstreamGrpcSenderProvider.java 60.00% 1 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (66.66%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8989      +/-   ##
============================================
+ Coverage     90.36%   90.38%   +0.01%     
- Complexity    10993    10995       +2     
============================================
  Files          1020     1020              
  Lines         30083    30096      +13     
  Branches       3931     3929       -2     
============================================
+ Hits          27185    27201      +16     
+ Misses         1939     1937       -2     
+ Partials        959      958       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jack-berg
jack-berg merged commit 3e2772d into open-telemetry:main Oct 30, 2026
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants