Repository navigation
Migrate to jackson 3 - #93
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (d != null && TypeUtils.isWholeNumberInLongRange(d)) { | ||
| gen.writeNumber(d.longValue()); | ||
| } else { | ||
| gen.writeNumber(d); |
Member
Author
|
Let's revisit this in the future, not required atm |
sspaink
force-pushed
the
migrate-jackson-3
branch
from
October 13, 2026 15:01
ef332dc to
d0edd0d
Compare
Move the SDK from Jackson 2.x (com.fasterxml.jackson.*) to Jackson 3.x
(tools.jackson.*) so we can pick up com.networknt:json-schema-validator
3.x, which dropped its Jackson 2 line.
Replace the abandoned com.github.java-json-tools:json-patch with an
inline RFC 6902 implementation in JsonBuiltins (no new dependency).
Jackson 3 behavior differences handled along the way:
- java.time support is built in, so jackson-datatype-jsr310 is dropped.
- Properties sort alphabetically by default; JacksonCapabilities opts
out so capabilities.json keeps its declaration order.
- asString() throws on container nodes where asText() returned "", so
json.patch path normalization uses asString("") to keep OPA parity.
- YAML parse errors now surface snakeyaml-engine's
MarkedYamlEngineException, unwrapped for Go-style "yaml: line N" text.
Signed-off-by: Sebastian Spaink <sebastianspaink@gmail.com>
sspaink
force-pushed
the
migrate-jackson-3
branch
from
October 13, 2026 15:02
d0edd0d to
b231f9d
Compare
Signed-off-by: Sebastian Spaink <sebastianspaink@gmail.com>
kroekle
approved these changes
Oct 13, 2026
kroekle
left a comment
kroekle
left a comment
Contributor
There was a problem hiding this comment.
Claude thinks that JsonBuiltins.java might be a little light on test coverage.
Overall the change seems to be backwards compatible, so LGTM
The upstream json-patch suite leaves gaps around the inline RFC 6902 engine: moving into an own child, the append token on remove/replace, copy independence, escaped segments and signed indices. Expected values come from opa eval against OPA 1.19.0. Signed-off-by: Sebastian Spaink <sebastianspaink@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the SDK from Jackson 2.x (
com.fasterxml.jackson.*) to Jackson 3.x (tools.jackson.*) so we can pick upcom.networknt:json-schema-validator:3.0.5, which dropped its Jackson 2 line. #52Swap the abandoned
com.github.java-json-tools:json-patchfor an inline RFC 6902 implementation inJsonBuiltins(no new dependency).